Switch web audio code to use FloatPoint3D instead of Vector3
Created attachment 75063 [details] Patch
Comment on attachment 75063 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=75063&action=review Are these the last uses of Vector3? If so, I think we should remove those files as well. Or is that planned in a separate patch? > WebCore/platform/graphics/FloatPoint3D.h:178 > +inline double distance(const FloatPoint3D& a, const FloatPoint3D& b) I'm not sure that adding this function to the global WebCore namespace is a good idea. Could it be expressed as a method "double distanceTo(const FloatPoint3D& other) const"?
Created attachment 75077 [details] Patch
> Are these the last uses of Vector3? If so, I think we should remove those files as well. Or is that planned in a separate patch? Yes, the new patch also removes wtf/Vector3.h >> WebCore/platform/graphics/FloatPoint3D.h:178 >> +inline double distance(const FloatPoint3D& a, const FloatPoint3D& b) > I'm not sure that adding this function to the global WebCore namespace is a good idea. Could it be expressed as a method "double distanceTo(const FloatPoint3D& other) const"? Yes, I've changed this method to distanceTo() as you propose.
Comment on attachment 75077 [details] Patch Looks good to me.
Committed r72853: <http://trac.webkit.org/changeset/72853>
http://trac.webkit.org/changeset/72853 might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: fast/profiler/throw-exception-from-eval.html