RESOLVED FIXED 50177
unloadable-script not testing both cases 
https://bugs.webkit.org/show_bug.cgi?id=50177
Summary unloadable-script not testing both cases
Gavin Peters
Reported 2010-11-29 13:36:25 PST
A recent issue 35404 changed the unloadable-script.html test to use a different requestResource failure mode: but only in one case. Fix it in both cases.
Attachments
Patch (1.92 KB, patch)
2010-11-29 13:41 PST, Gavin Peters 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Peters
Comment 1 2010-11-29 13:41:21 PST
Created attachment 75055 [details] Patch
Gavin Peters
Comment 2 2010-11-29 13:47:21 PST
Comment on attachment 75055 [details] Patch This patch fixes up an earlier CL, and should improve results on all platforms.
Ojan Vafai
Comment 3 2010-11-29 13:54:03 PST
Comment on attachment 75055 [details] Patch Patch looks good. Can you file a bug about this though? It seems chromium (i.e. V8?) was firing two errors with and without this change. So it seems like there may be a JSC bug lurking here. Marking cq-. I'll just commit this.
Ojan Vafai
Comment 4 2010-11-29 14:02:25 PST
Comment on attachment 75055 [details] Patch Clearing flags on attachment: 75055 Committed r72830: <http://trac.webkit.org/changeset/72830>
Ojan Vafai
Comment 5 2010-11-29 14:02:30 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.