Bug 50175 - layer()->currentTransform() is stale when layout changes the box size
: layer()->currentTransform() is stale when layout changes the box size
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering
: 528+ (Nightly build)
: All Mac OS X 10.5
: P2 Normal
Assigned To: Simon Fraser (smfr)
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-11-29 13:18 PST by Simon Fraser (smfr)
Modified: 2010-11-29 16:39 PST (History)
5 users (show)

See Also:


Attachments
Patch (10.74 KB, patch)
2010-11-29 15:06 PST, Simon Fraser (smfr)
hyatt: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2010-11-29 13:18:08 PST
layer()->currentTransform() can get stale; it's initially computed from RenderLayer::styleChanged, but the box size may be 0x0 at that point. When layout happens, the box-size can change, so the transform-origin (which depends on box size) changes, and the transform needs to be updated.
Comment 1 Simon Fraser (smfr) 2010-11-29 13:19:59 PST
Note: once this is fixed, we should be able to remove the updateTransform() in RenderBox::applyLayerTransformToRect().
Comment 2 Simon Fraser (smfr) 2010-11-29 15:06:57 PST
Created attachment 75069 [details]
Patch
Comment 3 Dave Hyatt 2010-11-29 15:09:36 PST
Comment on attachment 75069 [details]
Patch

r=me
Comment 4 Simon Fraser (smfr) 2010-11-29 15:14:28 PST
http://trac.webkit.org/changeset/72839
Comment 5 WebKit Review Bot 2010-11-29 15:43:15 PST
http://trac.webkit.org/changeset/72839 might have broken Qt Linux Release
The following tests are not passing:
fast/overflow/overflow-update-transform.html
Comment 6 Simon Fraser (smfr) 2010-11-29 16:37:58 PST
Reopening to fix some issues only seen in pixel tests.
Comment 7 Simon Fraser (smfr) 2010-11-29 16:39:38 PST
Ah, bug 50188 was filed to cover the failures.