RESOLVED FIXED Bug 50172
Add remaining custom JSC web audio bindings 
https://bugs.webkit.org/show_bug.cgi?id=50172
Summary Add remaining custom JSC web audio bindings
Chris Rogers
Reported 2010-11-29 12:34:58 PST
Add remaining custom JSC web audio bindings
Attachments
Patch (8.12 KB, patch)
2010-11-29 12:38 PST, Chris Rogers 		kbr: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Rogers
Comment 1 2010-11-29 12:38:13 PST
Created attachment 75051 [details] Patch
Kenneth Russell
Comment 2 2010-11-29 13:24:28 PST
Comment on attachment 75051 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=75051&action=review > WebCore/bindings/js/JSAudioBufferSourceNodeCustom.cpp:42 > + imp->setBuffer(toAudioBuffer(value)); Do you guard against NULL inputs in AudioBufferSourceNode::setBuffer? > WebCore/bindings/js/JSConvolverNodeCustom.cpp:42 > + imp->setBuffer(toAudioBuffer(value)); Same question about ConvolverNode here.
Chris Rogers
Comment 3 2010-11-29 13:30:26 PST
Comment on attachment 75051 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=75051&action=review >> WebCore/bindings/js/JSAudioBufferSourceNodeCustom.cpp:42 >> + imp->setBuffer(toAudioBuffer(value)); > > Do you guard against NULL inputs in AudioBufferSourceNode::setBuffer? Yes >> WebCore/bindings/js/JSConvolverNodeCustom.cpp:42 >> + imp->setBuffer(toAudioBuffer(value)); > > Same question about ConvolverNode here. Yes
Kenneth Russell
Comment 4 2010-11-29 14:48:47 PST
Comment on attachment 75051 [details] Patch OK, sounds good. r=me
Chris Rogers
Comment 5 2010-11-29 15:04:43 PST
Committed r72838: <http://trac.webkit.org/changeset/72838>
WebKit Review Bot
Comment 6 2010-11-29 19:02:50 PST
http://trac.webkit.org/changeset/72838 might have broken Leopard Intel Release (Tests) The following tests are not passing: fast/workers/storage/use-same-database-in-page-and-workers.html
Note You need to log in before you can comment on or make changes to this bug.