Bug 50168 – [chromium] try to enable WebCore compiler warnings on linux

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tony Chang]

[chromium] try to enable WebCore compiler warnings on linux

[Tony Chang]

Created attachment 75048 [details]
Patch

[Tony Chang]

This passes for me on hardy in a debug build and seems to pass on the bots in release (all the warnings are in third party code):
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Linux/builds/2769/steps/compile/logs/stdio

[James Robinson]

Comment on attachment 75048 [details]
Patch

Go for it!  I ran into completely nonsense-looking compile errors on the bots last time, so hopefully you'll have better luck.

[Tony Chang]

Committed r72824: <http://trac.webkit.org/changeset/72824>

[Tony Chang]

Meh, turning warnings off.  Here's the error:
cc1plus: warnings being treated as errors
WebCore/platform/Length.h: In constructor ‘WebCore::FillLayer::FillLayer(WebCore::EFillLayerType)’:
WebCore/platform/Length.h:56: warning: ‘this.7’ is used uninitialized in this function
WebCore/platform/Length.h:56: note: ‘this.7’ was declared here
WebCore/platform/Length.h:56: warning: ‘this.7’ is used uninitialized in this function
WebCore/platform/Length.h:56: note: ‘this.7’ was declared here
make: *** [out/Release/obj.target/webcore_remaining/WebCore/rendering/style/FillLayer.o] Error 1
make: *** Waiting for unfinished jobs....
cc1plus: warnings being treated as errors
WebCore/platform/graphics/Color.h: In constructor ‘WebCore::StyleBackgroundData::StyleBackgroundData()’:
WebCore/platform/graphics/Color.h:81: warning: ‘this.9’ is used uninitialized in this function
WebCore/platform/graphics/Color.h:81: note: ‘this.9’ was declared here
make: *** [out/Release/obj.target/webcore_remaining/WebCore/rendering/style/StyleBackgroundData.o] Error 1

[WebKit Review Bot]

http://trac.webkit.org/changeset/72824 might have broken Chromium Linux Release

[Tony Chang]

(In reply to comment #5)
> Meh, turning warnings off.  Here's the error:
> cc1plus: warnings being treated as errors
> WebCore/platform/Length.h: In constructor ‘WebCore::FillLayer::FillLayer(WebCore::EFillLayerType)’:
> WebCore/platform/Length.h:56: warning: ‘this.7’ is used uninitialized in this function
> WebCore/platform/Length.h:56: note: ‘this.7’ was declared here
> WebCore/platform/Length.h:56: warning: ‘this.7’ is used uninitialized in this function
> WebCore/platform/Length.h:56: note: ‘this.7’ was declared here
> make: *** [out/Release/obj.target/webcore_remaining/WebCore/rendering/style/FillLayer.o] Error 1

It looks like this is a compiler bug.  I'm trying to find a reasonable workaround that isn't too gross.  For example, in FillLayer.cpp, if I make the following change:

@@ -27,8 +27,8 @@ namespace WebCore {
 FillLayer::FillLayer(EFillLayerType type)
     : m_next(0)
     , m_image(FillLayer::initialFillImage(type))
-    , m_xPosition(FillLayer::initialFillXPosition(type))
-    , m_yPosition(FillLayer::initialFillYPosition(type))
+    , m_xPosition(Length(0.0, Percent))
+    , m_yPosition(Length(0.0, Percent))


it works (where FillLayer::initialFillXPosition just returns Length(0.0, Percent)).

Other options are to add a #pragma to the file to suppress the warning in gcc.  Maybe that's less bad.