Bug 50148 - [chromium] pass webframe to web frame client's cookieJar
Summary: [chromium] pass webframe to web frame client's cookieJar
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: jochen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-29 04:16 PST by jochen
Modified: 2010-11-30 02:36 PST (History)
2 users (show)

See Also:

Attachments
Patch (2.03 KB, patch)
2010-11-29 04:18 PST, jochen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2010-11-29 04:16:50 PST 
[chromium] pass webframe to web frame client's cookieJar
Comment 1 jochen 2010-11-29 04:18:28 PST 
Created attachment 75014 [details]
Patch
Comment 2 Darin Fisher (:fishd, Google) 2010-11-29 08:44:14 PST 
Comment on attachment 75014 [details]
Patch

To avoid breaking Chromium builds with this commit, I think you should
land a Chromium change first that has RenderView::cookieJar(WebFrame*)
implemented.  That way, when this patch lands, everything will continue
working.
Comment 3 jochen 2010-11-29 09:10:02 PST 
landed chromium side
Comment 4 WebKit Commit Bot 2010-11-29 14:32:46 PST 
Comment on attachment 75014 [details]
Patch

Rejecting patch 75014 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 2
Last 500 characters of output:
c++ com.apple.compilers.gcc.4_2
	CompileC /Projects/CommitQueue/WebKitBuild/WebCore.build/Debug/WebCore.build/Objects-normal/x86_64/RenderStyle.o /Projects/CommitQueue/WebCore/rendering/style/RenderStyle.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2
	CompileC /Projects/CommitQueue/WebKitBuild/WebCore.build/Debug/WebCore.build/Objects-normal/x86_64/RenderSVGContainer.o /Projects/CommitQueue/WebCore/rendering/RenderSVGContainer.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2
(358 failures)


Full output: http://queues.webkit.org/results/6400105
Comment 5 Adam Barth 2010-11-30 00:23:20 PST 
Comment on attachment 75014 [details]
Patch

Compile failed, but maybe try again?
Comment 6 WebKit Commit Bot 2010-11-30 01:17:21 PST 
Comment on attachment 75014 [details]
Patch

Rejecting patch 75014 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 2
Last 500 characters of output:
e/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/JSSVGPolygonElement.o /Projects/CommitQueue/WebKitBuild/Release/DerivedSources/WebCore/JSSVGPolygonElement.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2
	CompileC /Projects/CommitQueue/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/JSSVGStyleElement.o /Projects/CommitQueue/WebKitBuild/Release/DerivedSources/WebCore/JSSVGStyleElement.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2
(305 failures)


Full output: http://queues.webkit.org/results/6354102
Comment 7 jochen 2010-11-30 02:10:11 PST 
Comment on attachment 75014 [details]
Patch

trying commit queue once more after rolling chromium deps
Comment 8 WebKit Commit Bot 2010-11-30 02:36:37 PST 
Comment on attachment 75014 [details]
Patch

Clearing flags on attachment: 75014

Committed r72901: <http://trac.webkit.org/changeset/72901>
Comment 9 WebKit Commit Bot 2010-11-30 02:36:42 PST 
All reviewed patches have been landed.  Closing bug.