RESOLVED FIXED 50148
[chromium] pass webframe to web frame client's cookieJar 
https://bugs.webkit.org/show_bug.cgi?id=50148
Summary [chromium] pass webframe to web frame client's cookieJar
jochen
Reported 2010-11-29 04:16:50 PST
[chromium] pass webframe to web frame client's cookieJar
Attachments
Patch (2.03 KB, patch)
2010-11-29 04:18 PST, jochen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
jochen
Comment 1 2010-11-29 04:18:28 PST
Created attachment 75014 [details] Patch
Darin Fisher (:fishd, Google)
Comment 2 2010-11-29 08:44:14 PST
Comment on attachment 75014 [details] Patch To avoid breaking Chromium builds with this commit, I think you should land a Chromium change first that has RenderView::cookieJar(WebFrame*) implemented. That way, when this patch lands, everything will continue working.
jochen
Comment 3 2010-11-29 09:10:02 PST
landed chromium side
WebKit Commit Bot
Comment 4 2010-11-29 14:32:46 PST
Comment on attachment 75014 [details] Patch Rejecting patch 75014 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 2 Last 500 characters of output: c++ com.apple.compilers.gcc.4_2 CompileC /Projects/CommitQueue/WebKitBuild/WebCore.build/Debug/WebCore.build/Objects-normal/x86_64/RenderStyle.o /Projects/CommitQueue/WebCore/rendering/style/RenderStyle.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2 CompileC /Projects/CommitQueue/WebKitBuild/WebCore.build/Debug/WebCore.build/Objects-normal/x86_64/RenderSVGContainer.o /Projects/CommitQueue/WebCore/rendering/RenderSVGContainer.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2 (358 failures) Full output: http://queues.webkit.org/results/6400105
Adam Barth
Comment 5 2010-11-30 00:23:20 PST
Comment on attachment 75014 [details] Patch Compile failed, but maybe try again?
WebKit Commit Bot
Comment 6 2010-11-30 01:17:21 PST
Comment on attachment 75014 [details] Patch Rejecting patch 75014 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 2 Last 500 characters of output: e/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/JSSVGPolygonElement.o /Projects/CommitQueue/WebKitBuild/Release/DerivedSources/WebCore/JSSVGPolygonElement.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2 CompileC /Projects/CommitQueue/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/JSSVGStyleElement.o /Projects/CommitQueue/WebKitBuild/Release/DerivedSources/WebCore/JSSVGStyleElement.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2 (305 failures) Full output: http://queues.webkit.org/results/6354102
jochen
Comment 7 2010-11-30 02:10:11 PST
Comment on attachment 75014 [details] Patch trying commit queue once more after rolling chromium deps
WebKit Commit Bot
Comment 8 2010-11-30 02:36:37 PST
Comment on attachment 75014 [details] Patch Clearing flags on attachment: 75014 Committed r72901: <http://trac.webkit.org/changeset/72901>
WebKit Commit Bot
Comment 9 2010-11-30 02:36:42 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.