Bug 50134 - [Qt] Move some build logic from Qt to platform independent code
Summary: [Qt] Move some build logic from Qt to platform independent code
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
Keywords: Qt
Depends on:
Blocks: 50251
  Show dependency treegraph
Reported: 2010-11-28 08:58 PST by Laszlo Gombos
Modified: 2010-11-30 11:04 PST (History)
1 user (show)

See Also:

proposed change (2.91 KB, patch)
2010-11-28 09:11 PST, Laszlo Gombos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2010-11-28 08:58:58 PST
The step to create some directories for WebKit2 can be moved form WebKit2/DerivedSources.pro to WebKitTools/Scripts/generate-forwarding-headers.pl. Main motivation behind this was to fix a Symbian build break for Symbian.
Comment 1 Laszlo Gombos 2010-11-28 09:11:48 PST
Created attachment 74977 [details]
proposed change
Comment 2 Kenneth Rohde Christiansen 2010-11-28 10:08:08 PST
Comment on attachment 74977 [details]
proposed change

have you tested our webkit2 build? LGTM
Comment 3 WebKit Commit Bot 2010-11-28 10:31:31 PST
The commit-queue encountered the following flaky tests while processing attachment 74977 [details]:


Please file bugs against the tests.  These tests were authored by kmccullough@apple.com, oliver@apple.com, and timothy@apple.com.  The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2010-11-28 10:32:47 PST
Comment on attachment 74977 [details]
proposed change

Clearing flags on attachment: 74977

Committed r72779: <http://trac.webkit.org/changeset/72779>
Comment 5 WebKit Commit Bot 2010-11-28 10:32:52 PST
All reviewed patches have been landed.  Closing bug.