WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 50134
[Qt] Move some build logic from Qt to platform independent code
https://bugs.webkit.org/show_bug.cgi?id=50134
Summary
[Qt] Move some build logic from Qt to platform independent code
Laszlo Gombos
Reported
2010-11-28 08:58:58 PST
The step to create some directories for WebKit2 can be moved form WebKit2/DerivedSources.pro to WebKitTools/Scripts/generate-forwarding-headers.pl. Main motivation behind this was to fix a Symbian build break for Symbian.
Attachments
proposed change
(2.91 KB, patch)
2010-11-28 09:11 PST
,
Laszlo Gombos
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Laszlo Gombos
Comment 1
2010-11-28 09:11:48 PST
Created
attachment 74977
[details]
proposed change
Kenneth Rohde Christiansen
Comment 2
2010-11-28 10:08:08 PST
Comment on
attachment 74977
[details]
proposed change have you tested our webkit2 build? LGTM
WebKit Commit Bot
Comment 3
2010-11-28 10:31:31 PST
The commit-queue encountered the following flaky tests while processing
attachment 74977
[details]
: fast/profiler/throw-exception-from-eval.html Please file bugs against the tests. These tests were authored by
kmccullough@apple.com
,
oliver@apple.com
, and
timothy@apple.com
. The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 4
2010-11-28 10:32:47 PST
Comment on
attachment 74977
[details]
proposed change Clearing flags on attachment: 74977 Committed
r72779
: <
http://trac.webkit.org/changeset/72779
>
WebKit Commit Bot
Comment 5
2010-11-28 10:32:52 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug