Bug 50105 - Make IDBKeyRange match the spec
Summary: Make IDBKeyRange match the spec
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Jeremy Orlow
URL:
Keywords:
Depends on: 50093
Blocks:
  Show dependency treegraph
 
Reported: 2010-11-26 03:16 PST by Jeremy Orlow
Modified: 2010-11-26 08:37 PST (History)
3 users (show)

See Also:


Attachments
almost (42.08 KB, patch)
2010-11-26 03:17 PST, Jeremy Orlow
no flags Details | Formatted Diff | Diff
done (45.97 KB, patch)
2010-11-26 04:28 PST, Jeremy Orlow
steveblock: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Orlow 2010-11-26 03:16:20 PST
Remove flags and instead add two booleans for being open.
Comment 1 Jeremy Orlow 2010-11-26 03:17:49 PST
Created attachment 74911 [details]
almost

needs change log and has one bug in it, but It's 99% there
Comment 2 Hans Wennborg 2010-11-26 04:27:16 PST
Comment on attachment 74911 [details]
almost

View in context: https://bugs.webkit.org/attachment.cgi?id=74911&action=review

> WebCore/inspector/InspectorResourceAgent.cpp:349
> +    //m_frontend->setInitialContent(identifier, sourceString, type);

What's this?
Comment 3 Jeremy Orlow 2010-11-26 04:28:50 PST
Created attachment 74917 [details]
done

fixed the bug
Comment 4 Jeremy Orlow 2010-11-26 04:29:31 PST
(In reply to comment #2)
> (From update of attachment 74911 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=74911&action=review
> 
> > WebCore/inspector/InspectorResourceAgent.cpp:349
> > +    //m_frontend->setInitialContent(identifier, sourceString, type);
> 
> What's this?

Making Chrome build.  It's now removed (and fixed upstream, so I don't need it).
Comment 5 Andrei Popescu 2010-11-26 05:47:49 PST
LGTM
Comment 6 Jeremy Orlow 2010-11-26 08:37:34 PST
Committed r72767: <http://trac.webkit.org/changeset/72767>