Bug 50091 - [Qt] Passing multiple layout tests to DumpRenderTree doesn't work
Summary: [Qt] Passing multiple layout tests to DumpRenderTree doesn't work
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2010-11-25 11:08 PST by Robert Hogan
Modified: 2014-02-03 03:10 PST (History)
1 user (show)

See Also:


Attachments
Patch (1.41 KB, patch)
2010-11-25 11:42 PST, Robert Hogan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Hogan 2010-11-25 11:08:52 PST
For me, emitting done() results in the test dumping, resetting and loading the next test before m_hasDumped is reset to true.

Does this happen for anyone else?
Comment 1 Robert Hogan 2010-11-25 11:42:09 PST
Created attachment 74892 [details]
Patch
Comment 2 Csaba Osztrogonác 2010-11-26 01:16:52 PST
(In reply to comment #1)
> Created an attachment (id=74892) [details]
> Patch

It doesn't fix the bug for me. :(

$ WebKitBuild/Debug/bin/DumpRenderTree animations/animation-controller-drt-api.html animations/animation-css-rule-types.html
--> DRT still hangs after dumping the rendertree of the first test
Comment 3 Robert Hogan 2010-11-26 11:42:16 PST
(In reply to comment #2)
> (In reply to comment #1)
> > Created an attachment (id=74892) [details] [details]
> > Patch
> 
> It doesn't fix the bug for me. :(
> 
> $ WebKitBuild/Debug/bin/DumpRenderTree animations/animation-controller-drt-api.html animations/animation-css-rule-types.html
> --> DRT still hangs after dumping the rendertree of the first test

The plot thickens. I tried the patch on the QBAT VM and it worked well. But both here and on the VM I used the Release binary.
Comment 4 Robert Hogan 2010-12-02 11:08:53 PST
This also works for me on a debug build. So I don't know why we're getting different results.
Comment 5 Eric Seidel (no email) 2010-12-24 09:22:33 PST
Comment on attachment 74892 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=74892&action=review

OK.

> WebKitTools/ChangeLog:10
> +        https://bugs.webkit.org/show_bug.cgi?id=50091

Normally this is right under the bug title (at least when webkit-patch/prepare-ChangeLog fills it in for you).
Comment 6 Robert Hogan 2011-01-02 05:07:25 PST
Comment on attachment 74892 [details]
Patch

Hi Eric,
Should have removed the review flag since Ossy and I get different results with it, so not safe to land.
Comment 7 Jocelyn Turcotte 2014-02-03 03:10:28 PST
=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.