Bug 50069 - MathML: code cleaning needed in MathMLInlineContainerElement.cpp
Summary: MathML: code cleaning needed in MathMLInlineContainerElement.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: MathML (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.6
: P3 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-25 04:56 PST by François Sausset
Modified: 2010-11-26 10:01 PST (History)
3 users (show)

See Also:

Attachments
Patch (2.56 KB, patch)
2010-11-25 05:01 PST, François Sausset 		dbates: review+
dbates: commit-queue-
Details | Formatted Diff | Diff
Revised patch (2.70 KB, patch)
2010-11-26 01:39 PST, François Sausset 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description François Sausset 2010-11-25 04:56:05 PST 
remove unnecessary namespace & style adjustments
Comment 1 François Sausset 2010-11-25 05:01:12 PST 
Created attachment 74859 [details]
Patch
Comment 2 Daniel Bates 2010-11-25 12:45:17 PST 
Comment on attachment 74859 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=74859&action=review

Thank you for cleaning this up. I have some minor nits.

> WebCore/ChangeLog:6
> +        Remove unnecessary namespace & style adjustments
> +        https://bugs.webkit.org/show_bug.cgi?id=50069

Disregarding the name/date, Reviewed by, and changed files lines, the formatting convention of a change log entry is bug title; bug URL; then bug description. And the bug description should be a full sentence.

So, the change log for this patch should have the form:

...
MathML: code cleaning needed in MathMLInlineContainerElement.cpp
https://bugs.webkit.org/show_bug.cgi?id=50069

Remove unnecessary namespace & style adjustments.
...

See <http://webkit.org/coding/contributing.html#changelogs> as well as the referenced example <http://trac.webkit.org/changeset/43259>.

> WebCore/mathml/MathMLInlineContainerElement.cpp:82
>          return new (arena) RenderMathMLBlock(this);

Please un-indent this line of code so that it left-aligns with respect to the line "if (hasLocalName(mfencedTag))".
Comment 3 François Sausset 2010-11-26 01:39:38 PST 
Created attachment 74907 [details]
Revised patch

I just modified the log entry and removed the unnecessary tabulation.
Comment 4 WebKit Commit Bot 2010-11-26 09:24:22 PST 
The commit-queue encountered the following flaky tests while processing attachment 74907 [details]:

java/lc3/JSObject/ToObject-001.html
fast/profiler/throw-exception-from-eval.html

Please file bugs against the tests.  These tests were authored by ap@webkit.org, kmccullough@apple.com, oliver@apple.com, and timothy@apple.com.  The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2010-11-26 10:01:18 PST 
Comment on attachment 74907 [details]
Revised patch

Clearing flags on attachment: 74907

Committed r72773: <http://trac.webkit.org/changeset/72773>
Comment 6 WebKit Commit Bot 2010-11-26 10:01:24 PST 
All reviewed patches have been landed.  Closing bug.