Bug 50055 – Ensure that option elements are rendered with normal font weight on Windows/Linux

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ilya Sherman]

Ensure that option elements are rendered with normal font weight on Windows/Linux

[Ilya Sherman]

Created attachment 74833 [details]
Patch

[Ilya Sherman]

Created attachment 74834 [details]
Patch

[Ilya Sherman]

Comment on attachment 74834 [details]
Patch

I'm not sure if what I added is sufficient as a test for this.  Do I need to add test expectations somewhere?

[Ilya Sherman]

I should note: this arises from http://code.google.com/p/chromium/issues/detail?id=63919

I realized after uploading the most recent patchset that the proposed test doesn't work -- AFAICT the option elements only appear bold when the select element is clicked to bring up the select popup.  I don't know how to write a layout test to cover that case.  Could someone please point me in the right direction?

[Kent Tamura]

Comment on attachment 74834 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=74834&action=review

I think there is no way to make an automated test for this.

r- because of the testing issue.

> WebCore/ChangeLog:9
> +        * css/themeWin.css:
> +        (option): font-weight: normal !important;

It's not good to change themeWin.css for Chromium-only bug.
Can we fix this by C++ code, or introduce themeChromiumWin.css?

[Ilya Sherman]

Created attachment 74923 [details]
Patch

[Ilya Sherman]

Comment on attachment 74923 [details]
Patch

> It's not good to change themeWin.css for Chromium-only bug.
> Can we fix this by C++ code, or introduce themeChromiumWin.css?

Introduced themeChromiumSkia.css, which hopefully more accurately reflects that this affects both Windows and Linux

[Kent Tamura]

Comment on attachment 74923 [details]
Patch

looks good.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 74923 [details]:

transitions/transition-end-event-transform.html
java/argument-to-object-type.html

Please file bugs against the tests.  These tests were authored by [e-mail], [e-mail], [e-mail], and [e-mail].  The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 74923 [details]:

transitions/transition-end-event-transform.html

Please file bugs against the tests.  These tests were authored by [e-mail], [e-mail], and [e-mail].  The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 74923 [details]
Patch

Clearing flags on attachment: 74923

Committed r72860: <http://trac.webkit.org/changeset/72860>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.