Bug 50054 – [Chromium] Use libjpeg-turbo instead of libjpeg

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Hironori Bono]

(Copied from <http://crbug.com/48789> since we need to change the 'WebKit.gyp' file.)

> libjpeg-turbo is binary compatible with libjpeg but 2-4x faster.
>
> Worth looking into to make Chrome even faster?

[Hironori Bono]

Created attachment 75789 [details]
A refactoring change

[WebKit Review Bot]

Attachment 75789 [details] did not pass style-queue:

Failed to run "[u'git', u'reset', u'--hard', u'refs/remotes/trunk']" exit_code: 128
error: Could not write new index file.
fatal: Could not reset index file to revision 'refs/remotes/trunk'.


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Attachment 75789 [details] did not pass style-queue:

Failed to run "[u'git', u'reset', u'--hard', u'refs/remotes/trunk']" exit_code: 128
error: Could not write new index file.
fatal: Could not reset index file to revision 'refs/remotes/trunk'.


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Attachment 75789 [details] did not pass style-queue:

Failed to run "[u'git', u'reset', u'--hard', u'refs/remotes/trunk']" exit_code: 128
error: Could not write new index file.
fatal: Could not reset index file to revision 'refs/remotes/trunk'.


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Attachment 75789 [details] did not pass style-queue:

Failed to run "[u'git', u'reset', u'--hard', u'refs/remotes/trunk']" exit_code: 128
error: Could not write new index file.
fatal: Could not reset index file to revision 'refs/remotes/trunk'.


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Attachment 75789 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/6820096

[Hironori Bono]

Created attachment 75866 [details]
The second change

Oops, my previous change causes a build break on canary bots because of the lack of 'libjpeg_gyp_path'. I have updated this change so it works well with WebKit canary bots.

Regards,

Hironori Bono

[WebKit Review Bot]

Attachment 75789 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/update-webkit']" exit_code: 2
Updating OpenSource
Incomplete data: Delta source ended unexpectedly at /usr/lib/git-core/git-svn line 5061

Died at WebKitTools/Scripts/update-webkit line 132.


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Attachment 75866 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/update-webkit']" exit_code: 2
Updating OpenSource
Incomplete data: Delta source ended unexpectedly at /usr/lib/git-core/git-svn line 5061

Died at WebKitTools/Scripts/update-webkit line 132.


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Comment on attachment 75866 [details]
The second change

Clearing flags on attachment: 75866

Committed r73736: <http://trac.webkit.org/changeset/73736>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Tony Chang]

Comment on attachment 75866 [details]
The second change

View in context: https://bugs.webkit.org/attachment.cgi?id=75866&action=review

> WebCore/ChangeLog:12
> +        This change replaces the hard-coded path to the GYP files of the JPEG
> +        library with a 'libjpeg_gyp_path' variable, which is added by Chromium
> +        r68453. (When building WebKit Chromium, this change sets its value to
> +        '<(chromium_src_dir)/third_party/libjpeg/libjpeg.gyp' to avoid changing
> +        the current behavior.)

Just so I understand, this makes use use regular libjpeg for WebKit only checkouts and libjpeg-turbo when in a chromium checkout, right?  Can we have WebKit only checkouts use libjpeg-turbo too?

[Hironori Bono]

Greetings Tony,

Thank you for your comments.

(In reply to comment #12)
> Just so I understand, this makes use use regular libjpeg for WebKit only checkouts and libjpeg-turbo when in a chromium checkout, right?

Yes, you are totally correct. :)

> Can we have WebKit only checkouts use libjpeg-turbo too?

Unfortunately, not for now. We notice we need to update our patched yasm to build libjpeg-turbo on Mac because of yasm Ticket #186. <http://www.tortall.net/projects/yasm/ticket/186>. (Our yasm is based on yasm 0.8, which does not integrate the fix for this bug.) When we update our yasm and verified we can build libjpeg-turbo on Mac, I will send another change to switch our WebKit build to use libjpeg-turbo. (It changes "WebKit/chromium/DEPS" and pull libjpeg-turbo and our patched yasm to the WebKit tree.) By the way, we can use libjpeg-turbo only on Windows and on Mac since Linux uses the system JPEG library.
Is it OK for you?

Regards,

Hironori Bono

[Tony Chang]

(In reply to comment #13)
> Unfortunately, not for now. We notice we need to update our patched yasm to build libjpeg-turbo on Mac because of yasm Ticket #186. <http://www.tortall.net/projects/yasm/ticket/186>. (Our yasm is based on yasm 0.8, which does not integrate the fix for this bug.) When we update our yasm and verified we can build libjpeg-turbo on Mac, I will send another change to switch our WebKit build to use libjpeg-turbo. (It changes "WebKit/chromium/DEPS" and pull libjpeg-turbo and our patched yasm to the WebKit tree.) By the way, we can use libjpeg-turbo only on Windows and on Mac since Linux uses the system JPEG library.
> Is it OK for you?

Sounds good to me, thanks Hironori!