Bug 50036 - update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment
Summary: update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-24 12:52 PST by sccameron
Modified: 2011-01-31 14:33 PST (History)
4 users (show)

See Also:


Attachments
Added httpd configuration file and modification to run Apache2.2 in MSYS environment (31.35 KB, patch)
2010-11-24 12:56 PST, sccameron
darin: review+
Details | Formatted Diff | Diff
Same patch with the addition of ChangeLogs and moved from WebKitTools/ to Tools/ (33.39 KB, patch)
2011-01-04 08:25 PST, sccameron
dbates: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description sccameron 2010-11-24 12:52:43 PST
I'd like to propose adding functionality of running an HTTPD service via run-webkit-httpd in an MSYS environment.

This would require that the user installs the Win32 Binary including OpenSSL from http://httpd.apache.org/download.cgi#apache22.

Apache2.2 for Win32 does not come with PHP5 modules.  The loading of these modules will therefore be disabled in the Apache2.2 configuration that I propose.  They could however be installed separately from http://windows.php.net/download/.
Comment 1 sccameron 2010-11-24 12:56:06 PST
Created attachment 74785 [details]
Added httpd configuration file and modification to run Apache2.2 in MSYS environment

NOTE: The apache2-msys-httpd.conf has been merged with apache2-httpd.conf.
The diff< ServerRoot "/usr"
---
> ServerRoot "C:/Program Files/Apache Software Foundation/Apache2.2"
68c68
< LockFile "/tmp/WebKit/httpd.lock"
---
> #LockFile "/tmp/WebKit/httpd.lock"
121,122c121,122
< MinSpareServers 1
< MaxSpareServers 5
---
> #MinSpareServers 1
> #MaxSpareServers 5
128c128
< StartServers 1
---
> #StartServers 1
137c137
< MaxClients 150
---
> #MaxClients 150
153c153
< MaxRequestsPerChild 100000
---
> #MaxRequestsPerChild 100000
169,171c169,171
< Listen [::1]:8000
< Listen [::1]:8080
< Listen [::1]:8443
---
> #Listen [::1]:8000
> #Listen [::1]:8080
> #Listen [::1]:8443
189,251c189,252

With the addition of some differences in modules.
Comment 2 Eric Seidel (no email) 2010-12-12 02:39:38 PST
Comment on attachment 74785 [details]
Added httpd configuration file and modification to run Apache2.2 in MSYS environment

The madness must top!  Yet another copy/paste httpd.conf :(
Comment 3 Eric Seidel (no email) 2010-12-12 02:40:20 PST
Also, I thougth the world had moved to new-run-webkit-httpd?
Comment 4 sccameron 2011-01-04 08:25:55 PST
Created attachment 77891 [details]
Same patch with the addition of ChangeLogs and moved from WebKitTools/ to Tools/

This is the same patch with the addition of Tools/ChangeLog and LayoutTests/ChangeLog files.
Also, the patch has been moved from WebKitTools/ to Tools/ to match recent changes.
Comment 5 Daniel Bates 2011-01-31 13:54:16 PST
(In reply to comment #2)
> (From update of attachment 74785 [details])
> The madness must top!  Yet another copy/paste httpd.conf :(

The httpd.conf file included in the patch consists of some Windows-specific changes related to running run-webkit-httpd from within the MinGW command prompt. These changes include changing the location of the ServerRoot, and the location of Apache2 modules (from libexec/apache2/ to modules/). We were unclear how to change such settings using the command line and/or use Windows junctions effectively.

We should look to try to extract the common bits from these Apache configuration file into shared files. I suggest we do such refactoring in a separate bug.

If you have any additional ideas/suggestions on this issue, we would appreciate it.
Comment 6 Daniel Bates 2011-01-31 14:00:27 PST
Comment on attachment 77891 [details]
Same patch with the addition of ChangeLogs and moved from WebKitTools/ to Tools/

View in context: https://bugs.webkit.org/attachment.cgi?id=77891&action=review

Looks good to me.

> Tools/Scripts/run-webkit-httpd:5
> +# Copyright (C) Research In Motion Limited 2010. All rights reserved.

Nit: 2010 should be 2011.

> Tools/Scripts/webkitperl/httpd.pm:4
> +# Copyright (C) Research In Motion Limited 2010. All rights reserved.

Ditto.

> Tools/Scripts/webkitperl/httpd.pm:82
> +        $httpdPath = "/c/program\ files/apache\ software\ foundation/apache2.2/bin/httpd.exe";

It would be nicer if we could write this in such a way that we didn't need to escape the space characters in the path.
Comment 7 Daniel Bates 2011-01-31 14:05:16 PST
(In reply to comment #3)
> Also, I thougth the world had moved to new-run-webkit-httpd?

Not yet. It's probably best to address such a transition on webkit-dev.
Comment 8 Daniel Bates 2011-01-31 14:33:21 PST
Committed r77161: <http://trac.webkit.org/changeset/77161>