Bug 50034 - [GTK] Make kit() methods return the proper type instead of gpointer
Summary: [GTK] Make kit() methods return the proper type instead of gpointer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-24 11:05 PST by Xan Lopez
Modified: 2010-12-14 04:29 PST (History)
3 users (show)

See Also:

Attachments
kit.diff (15.09 KB, patch)
2010-11-24 11:10 PST, Xan Lopez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xan Lopez 2010-11-24 11:05:22 PST 
Saves us quite a bit of mindless casting.
Comment 1 Xan Lopez 2010-11-24 11:10:24 PST 
Created attachment 74780 [details]
kit.diff
Comment 2 Martin Robinson 2010-11-24 11:12:25 PST 
Comment on attachment 74780 [details]
kit.diff

Awesome!
Comment 3 WebKit Review Bot 2010-11-24 11:12:31 PST 
Attachment 74780 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebCore/ChangeLog', u'WebCore/bindings/gobject/WebKitDOMBinding.cpp', u'WebCore/bindings/gobject/WebKitDOMBinding.h', u'WebCore/bindings/scripts/CodeGeneratorGObject.pm', u'WebKit/gtk/ChangeLog', u'WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp', u'WebKit/gtk/webkit/webkitprivate.cpp', u'WebKit/gtk/webkit/webkitwebview.cpp']" exit_code: 1
WebCore/bindings/gobject/WebKitDOMBinding.h:28:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Eric Seidel (no email) 2010-12-14 01:34:02 PST 
Seems like this just needs a small style update and landing.
Comment 5 Xan Lopez 2010-12-14 04:29:48 PST 
Comment on attachment 74780 [details]
kit.diff

This landed in r72691, my apologies for not closing the bug.
Comment 6 Xan Lopez 2010-12-14 04:29:59 PST 
Closing.