RESOLVED FIXED 50031
[WINCE] Implement WebCore::directoryName 
https://bugs.webkit.org/show_bug.cgi?id=50031
Summary [WINCE] Implement WebCore::directoryName
Patrick R. Gansterer
Reported 2010-11-24 09:04:41 PST
see patch
Attachments
Patch (3.05 KB, patch)
2010-11-24 09:11 PST, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (3.05 KB, patch)
2010-11-24 09:37 PST, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (3.05 KB, patch)
2010-11-24 09:40 PST, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2010-11-24 09:11:25 PST
Created attachment 74767 [details] Patch
WebKit Review Bot
Comment 2 2010-11-24 09:16:34 PST
Attachment 74767 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebCore/ChangeLog', u'WebCore/platform/wince/FileSystemWinCE.cpp']" exit_code: 1 WebCore/platform/wince/FileSystemWinCE.cpp:40: Use 'using namespace std;' instead of 'using std::max;'. [build/using_std] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Patrick R. Gansterer
Comment 3 2010-11-24 09:37:23 PST
Created attachment 74770 [details] Patch
WebKit Review Bot
Comment 4 2010-11-24 09:38:58 PST
Attachment 74770 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebCore/ChangeLog', u'WebCore/platform/wince/FileSystemWinCE.cpp']" exit_code: 1 WebCore/platform/wince/FileSystemWinCE.cpp:40: Use 'using namespace std;' instead of 'using std::max;'. [build/using_std] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Patrick R. Gansterer
Comment 5 2010-11-24 09:40:13 PST
Created attachment 74773 [details] Patch
WebKit Commit Bot
Comment 6 2010-11-29 08:30:27 PST
The commit-queue encountered the following flaky tests while processing attachment 74773 [details]: fast/workers/storage/use-same-database-in-page-and-workers.html compositing/iframes/overlapped-nested-iframes.html Please file bugs against the tests. These tests were authored by dumi@chromium.org and simon.fraser@apple.com. The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 7 2010-11-29 10:16:39 PST
The commit-queue encountered the following flaky tests while processing attachment 74773 [details]: fast/profiler/throw-exception-from-eval.html Please file bugs against the tests. These tests were authored by kmccullough@apple.com, oliver@apple.com, and timothy@apple.com. The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 8 2010-11-29 10:17:50 PST
Comment on attachment 74773 [details] Patch Clearing flags on attachment: 74773 Committed r72809: <http://trac.webkit.org/changeset/72809>
WebKit Commit Bot
Comment 9 2010-11-29 10:17:55 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.