WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 50029
Web Inspector: place local modifications to under original resource nodes in the resource panel.
https://bugs.webkit.org/show_bug.cgi?id=50029
Summary
Web Inspector: place local modifications to under original resource nodes in ...
Pavel Feldman
Reported
2010-11-24 09:00:35 PST
Patch to follow.
Attachments
[PATCH] Proposed change.
(19.29 KB, patch)
2010-11-24 09:29 PST
,
Pavel Feldman
yurys
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Pavel Feldman
Comment 1
2010-11-24 09:29:35 PST
Created
attachment 74769
[details]
[PATCH] Proposed change.
Yury Semikhatsky
Comment 2
2010-11-24 09:50:11 PST
Comment on
attachment 74769
[details]
[PATCH] Proposed change. View in context:
https://bugs.webkit.org/attachment.cgi?id=74769&action=review
> WebCore/inspector/front-end/Resource.js:639 > + overrideContent: function(content)
This method should be renamed to setInitialContent
> WebCore/inspector/front-end/SourceView.js:151 > + this.resource.content = newContent;
Move this line to _editLineComplete.
> WebCore/inspector/front-end/SourceView.js:155 > + _editLineComplete: function(scrollTop)
scrollTop is not used.
Pavel Feldman
Comment 3
2010-11-24 10:06:48 PST
M WebCore/ChangeLog M WebCore/English.lproj/localizedStrings.js M WebCore/inspector/Inspector.idl M WebCore/inspector/InspectorController.cpp M WebCore/inspector/InspectorResourceAgent.cpp M WebCore/inspector/InspectorResourceAgent.h M WebCore/inspector/front-end/CSSStyleModel.js M WebCore/inspector/front-end/NetworkPanel.js M WebCore/inspector/front-end/Resource.js M WebCore/inspector/front-end/ResourceManager.js M WebCore/inspector/front-end/ResourcesPanel.js M WebCore/inspector/front-end/SourceFrame.js M WebCore/inspector/front-end/SourceView.js M WebCore/inspector/front-end/StylesSidebarPane.js Committed
r72684
WebKit Review Bot
Comment 4
2010-11-24 11:07:44 PST
http://trac.webkit.org/changeset/72684
might have broken Leopard Intel Release (Tests)
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug