Our RunLoop::Timer implementation lacks support for repeating timers. Let's fix this.
Created attachment 74760 [details] Patch
Comment on attachment 74760 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=74760&action=review > WebKit2/Platform/qt/RunLoopQt.cpp:116 > + ASSERT(!repeatInterval || nextFireInterval == repeatInterval); Hmm. This seems mysterious. Will nextFireInterval always == repeatInterval for repeat timers? If so, this function should be changed to take a "bool isSingleShot" instead of a second interval IMO.
(In reply to comment #2) > (From update of attachment 74760 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=74760&action=review > > > WebKit2/Platform/qt/RunLoopQt.cpp:116 > > + ASSERT(!repeatInterval || nextFireInterval == repeatInterval); > > Hmm. This seems mysterious. Will nextFireInterval always == repeatInterval for repeat timers? > If so, this function should be changed to take a "bool isSingleShot" instead of a second interval IMO. Right. I would not like to touch the common part, but that was not the right decision.
Should be fixed on Windows as well.
Created attachment 74938 [details] Patch
Comment on attachment 74938 [details] Patch Clearing flags on attachment: 74938 Committed r72816: <http://trac.webkit.org/changeset/72816>
All reviewed patches have been landed. Closing bug.