Web Inspector: set DOM breakpoints by path

[Pavel Podivilov]

Web Inspector: set DOM breakpoints by path

[Pavel Podivilov]

Created attachment 74748 [details]
Patch.

[Pavel Podivilov]

Currently, restoring breakpoint requires additional round-trip to convert path to nodeId. As a result, breakpoint won't hit on early event after page reload.

[Yury Semikhatsky]

Comment on attachment 74748 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=74748&action=review

> WebCore/ChangeLog:5
> +        Web Inspector: set DOM breakpoints by path

Please provide more detailed description on the purpose of this change.

> WebCore/inspector/InspectorDOMAgent.cpp:787
> +    m_idToBreakpoint.set(breakpointId, breakpoint);

I'd still rather use some compound id string instead of this two way mapping or even better use dedicated methods for set/remove/hit breakpoint for different breakpoint types. It may be more code but the design will be clearer than these mappings from surrogate ids to breakpoints and back.

> WebCore/inspector/front-end/BreakpointManager.js:475
> +        if (this._nodeId) {

Prefer early return.

[Pavel Podivilov]

Committed r72727: <http://trac.webkit.org/changeset/72727>