WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
50017
Web Inspector: set DOM breakpoints by path
https://bugs.webkit.org/show_bug.cgi?id=50017
Summary
Web Inspector: set DOM breakpoints by path
Pavel Podivilov
Reported
2010-11-24 04:51:34 PST
Web Inspector: set DOM breakpoints by path
Attachments
Patch.
(22.44 KB, patch)
2010-11-24 04:52 PST
,
Pavel Podivilov
yurys
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Pavel Podivilov
Comment 1
2010-11-24 04:52:17 PST
Created
attachment 74748
[details]
Patch.
Pavel Podivilov
Comment 2
2010-11-24 05:19:55 PST
Currently, restoring breakpoint requires additional round-trip to convert path to nodeId. As a result, breakpoint won't hit on early event after page reload.
Yury Semikhatsky
Comment 3
2010-11-24 07:22:32 PST
Comment on
attachment 74748
[details]
Patch. View in context:
https://bugs.webkit.org/attachment.cgi?id=74748&action=review
> WebCore/ChangeLog:5 > + Web Inspector: set DOM breakpoints by path
Please provide more detailed description on the purpose of this change.
> WebCore/inspector/InspectorDOMAgent.cpp:787 > + m_idToBreakpoint.set(breakpointId, breakpoint);
I'd still rather use some compound id string instead of this two way mapping or even better use dedicated methods for set/remove/hit breakpoint for different breakpoint types. It may be more code but the design will be clearer than these mappings from surrogate ids to breakpoints and back.
> WebCore/inspector/front-end/BreakpointManager.js:475 > + if (this._nodeId) {
Prefer early return.
Pavel Podivilov
Comment 4
2010-11-25 05:57:12 PST
Committed
r72727
: <
http://trac.webkit.org/changeset/72727
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug