Bug 50008 - Merge the usage of jumps and calls at ARM-JIT
Summary: Merge the usage of jumps and calls at ARM-JIT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other All
: P2 Enhancement
Assignee: Gabor Loki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-24 00:38 PST by Gabor Loki
Modified: 2010-11-24 05:05 PST (History)
1 user (show)

See Also:


Attachments
Merge the usage of jumps and calls at ARM-JIT (6.37 KB, patch)
2010-11-24 00:50 PST, Gabor Loki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Loki 2010-11-24 00:38:57 PST
Currently, those JmpSrc objects which represent jumps point to the address of branches, and the JmpSrc objects which represent calls point to the return address of calls (after the branch instruction). The JmpSrc objects point to after the jump instruction on all other JITs. So, the ARM JIT should follow this method also.
Comment 1 Gabor Loki 2010-11-24 00:50:36 PST
Created attachment 74730 [details]
Merge the usage of jumps and calls at ARM-JIT

I have not seen any performance issues.
Comment 2 WebKit Commit Bot 2010-11-24 05:04:55 PST
Comment on attachment 74730 [details]
Merge the usage of jumps and calls at ARM-JIT

Clearing flags on attachment: 74730

Committed r72663: <http://trac.webkit.org/changeset/72663>
Comment 3 WebKit Commit Bot 2010-11-24 05:05:00 PST
All reviewed patches have been landed.  Closing bug.