Bug 50002 – DRT should not generate pixel output for text/plain tests

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Mihai Parparita]

DRT should not generate pixel output for text/plain tests

[Mihai Parparita]

Created attachment 74721 [details]
Patch

[David Levin]

Comment on attachment 74721 [details]
Patch

It feels like this change should also delete the pixel results for the one test that will now no longer use them.

[Mihai Parparita]

(In reply to comment #2)
> (From update of attachment 74721 [details])
> It feels like this change should also delete the pixel results for the one test that will now no longer use them.

We didn't have any pixel results for http/tests/slow-utf8-text.pl, that's how I noticed this discrepancy in the first place (I'm working on updating the Mac baselines for Snow Leopard, so I've been running all tests through the Mac port's DRT with pixel tests enabled, which the bots don't do).

Will wait for the EWS to process this patch before landing it, since I made the Windows and GTK changes blindly locally.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 74721 [details]:

fast/history/history-subframe-with-name.html
compositing/iframes/overlapped-nested-iframes.html

Please file bugs against the tests.  These tests were authored by [e-mail] and [e-mail].  The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 74721 [details]
Patch

Clearing flags on attachment: 74721

Committed r72694: <http://trac.webkit.org/changeset/72694>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.