Created attachment 74715 [details]
(In reply to comment #2)
Good point. We don't want to break building trunk WebKit inside Qt,
so we shouldn't land it now. I propose to fix it in Qt and after
the new Qt release land this fix.
There might be an opportunity to fix this in Qt5 if there is an interest. Simon, what do you think ?
Comment on attachment 74715 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=74715&action=review
> + contains(DEFINES, ENABLE_JIT=1): error("'ENABLE_JIT=1' not supported with valgrind, setting ENABLE_JIT=0")
This check is not correct, with --smc-check=all-non-file valgrind appears to work just fine.
Yeah, let's get rid of this variable. I believe we've already removed the corresponding "configure option" from qt's configure.
Created attachment 167612 [details]
As Simon indicated valgrind might work with JIT enabled. Potentially in valgrind.prf the following line would make more sense
-DEFINES += ENABLE_JIT=0
+enable?(jit): DEFINES += ENABLE_JIT=0
I am happy to make that change or perhaps it could be in a follow-up patch.
Comment on attachment 167612 [details]
Clearing flags on attachment: 167612
Committed r130728: <http://trac.webkit.org/changeset/130728>
All reviewed patches have been landed. Closing bug.