Bug 49990 - [Qt] Selecting shadowed text causes rendering artifacts
Summary: [Qt] Selecting shadowed text causes rendering artifacts
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2010-11-23 13:34 PST by Andreas Kling
Modified: 2010-11-23 14:51 PST (History)
3 users (show)

See Also:


Attachments
Test page illustrating the problem (140 bytes, text/html)
2010-11-23 13:35 PST, Andreas Kling
no flags Details
Screenshot of rendering when text is partially selected (25.89 KB, image/png)
2010-11-23 13:36 PST, Andreas Kling
no flags Details
Proposed patch (2.18 KB, patch)
2010-11-23 13:37 PST, Andreas Kling
no flags Details | Formatted Diff | Diff
Proposed patch v2 (2.16 KB, patch)
2010-11-23 13:47 PST, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2010-11-23 13:34:17 PST
When selecting text with a text-shadow from the end of the word, insufficient space is allocated for the shadow generation, and we end up with a partial shadow.
Comment 1 Andreas Kling 2010-11-23 13:35:59 PST
Created attachment 74691 [details]
Test page illustrating the problem
Comment 2 Andreas Kling 2010-11-23 13:36:55 PST
Created attachment 74692 [details]
Screenshot of rendering when text is partially selected
Comment 3 Andreas Kling 2010-11-23 13:37:43 PST
Created attachment 74693 [details]
Proposed patch
Comment 4 Andreas Kling 2010-11-23 13:47:38 PST
Created attachment 74694 [details]
Proposed patch v2
Comment 5 Early Warning System Bot 2010-11-23 13:48:26 PST
Attachment 74693 [details] did not build on qt:
Build output: http://queues.webkit.org/results/6338018
Comment 6 WebKit Commit Bot 2010-11-23 14:22:27 PST
The commit-queue encountered the following flaky tests while processing attachment 74694 [details]:

inspector/styles-new-API.html
fast/profiler/throw-exception-from-eval.html

Please file bugs against the tests.  These tests were authored by apavlov@chromium.org, kmccullough@apple.com, oliver@apple.com, and timothy@apple.com.  The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2010-11-23 14:51:53 PST
Comment on attachment 74694 [details]
Proposed patch v2

Clearing flags on attachment: 74694

Committed r72630: <http://trac.webkit.org/changeset/72630>
Comment 8 WebKit Commit Bot 2010-11-23 14:51:59 PST
All reviewed patches have been landed.  Closing bug.