Bug 49983 - Remove Bakefile build system files
Summary: Remove Bakefile build system files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on: 34022
Blocks:
  Show dependency treegraph
 
Reported: 2010-11-23 10:48 PST by Patrick R. Gansterer
Modified: 2010-12-21 01:06 PST (History)
2 users (show)

See Also:


Attachments
Patch (8.43 KB, patch)
2010-11-23 10:52 PST, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2010-11-23 10:48:16 PST
see patch
Comment 1 Patrick R. Gansterer 2010-11-23 10:52:25 PST
Created attachment 74682 [details]
Patch

r53757 only removed the content, but not the files.
This patch removes that empty files.
Comment 2 Csaba Osztrogonác 2010-11-24 04:26:07 PST
Comment on attachment 74682 [details]
Patch

r=me, but please mention in changelogs that "r53757 only removed the content, but not the files.
This patch removes that empty files." And add changelog entry to WebKit directory too.
Comment 3 Patrick R. Gansterer 2010-11-24 07:39:58 PST
Comment on attachment 74682 [details]
Patch

Clearing flags on attachment: 74682

Manually committed r72669: <http://trac.webkit.org/changeset/72669>
Comment 4 Patrick R. Gansterer 2010-11-24 07:40:20 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Eric Seidel (no email) 2010-12-21 00:30:41 PST
When this was committed, it added a non-utf8 character to WebKit/wx/ChangeLog. Which caused issues when processing bug 51382.  At least I think it was from this change.
Comment 6 Patrick R. Gansterer 2010-12-21 01:06:32 PST
(In reply to comment #5)
> When this was committed, it added a non-utf8 character to WebKit/wx/ChangeLog. Which caused issues when processing bug 51382.  At least I think it was from this change.
Seams that there was no non-ascii character in the file before and i commited it with the wrong encoding. Sorry.
Can we add a svn pre commit hook on text files to avoid such problems?