Bug 49963 – V8 binding for DOMTimeStamp should be Number, not Date

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit API

[John Knottenbelt]

The W3C DOM Level 3 Core TR currently differs from standard practice in that the TR states that DOMTimeStamp should be bound to a Date object in ECMAScript ( http://www.w3.org/TR/DOM-Level-3-Core/core.html#Core-DOMTimeStamp ). 

Initially, I had thought that JSC in WebKit needed to change ( https://bugs.webkit.org/show_bug.cgi?id=49589 ), but in practice, most existing implementations bind DOMTimeStamp to a Number. This was observed on what-wg before ( http://www.mail-archive.com/[e-mail]/msg13626.html ) and an intention was made to change the DOM Core 3 so that DOMTimeStamp be bound to a number for ECMAScript ( http://www.w3.org/TR/DOM-Level-3-Events/#changes-DOMLevel2to3Changes ):

"Event.timeStamp is now a Number in the ECMAScript binding; a proposed correction to make the same change in [DOM3 Core] is forthcoming."

The action is here: http://www.w3.org/2008/webapps/track/actions/417

So, the V8 WebKit binding for DOMTimeStamp should be changed from Date to Number.

[John Knottenbelt]

DOMTimeStamp has now moved out to Web IDL - the current development version of  DOM Core can be found at http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html

And the development version of Web IDL can be found here:
http://dev.w3.org/2006/webapi/WebIDL/#common-DOMTimeStamp

[John Knottenbelt]

Created attachment 74931 [details]
Patch

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 74931 [details]:

compositing/iframes/overlapped-nested-iframes.html
fast/workers/storage/use-same-database-in-page-and-workers.html

Please file bugs against the tests.  These tests were authored by [e-mail] and [e-mail].  The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 74931 [details]:

inspector/elements-panel-xhtml-structure.xhtml

Please file bugs against the tests.  These tests were authored by [e-mail] and [e-mail].  The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 74931 [details]
Patch

Clearing flags on attachment: 74931

Committed r72912: <http://trac.webkit.org/changeset/72912>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.