WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
49955
Remove unused class "Pen" in WebCore/platform/graphics
https://bugs.webkit.org/show_bug.cgi?id=49955
Summary
Remove unused class "Pen" in WebCore/platform/graphics
Andreas Kling
Reported
2010-11-22 19:54:52 PST
There's a Pen class in WebCore/platform/graphics/ that's not used by anything, we should remove it.
Attachments
Proposed patch
(17.34 KB, patch)
2011-01-07 05:31 PST
,
Andreas Kling
darin
: review+
commit-queue
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Andreas Kling
Comment 1
2011-01-07 05:31:11 PST
Created
attachment 78223
[details]
Proposed patch
WebKit Commit Bot
Comment 2
2011-01-07 12:26:27 PST
Comment on
attachment 78223
[details]
Proposed patch Rejecting
attachment 78223
[details]
from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-sf-cq', 'apply-attachment', '--no-update', '--non-interactive', 78223]" exit_code: 2 Last 500 characters of output: orm/graphics/Pen.cpp rm 'WebCore/platform/graphics/Pen.cpp' patching file WebCore/platform/graphics/Pen.h rm 'WebCore/platform/graphics/Pen.h' patching file WebCore/platform/graphics/haiku/GraphicsContextHaiku.cpp patching file WebCore/platform/graphics/wx/GraphicsContextWx.cpp patching file WebCore/platform/graphics/wx/PenWx.cpp rm 'WebCore/platform/graphics/wx/PenWx.cpp' Failed to run "[u'/Projects/CommitQueue/Tools/Scripts/svn-apply', u'--reviewer', u'Darin Adler', u'--force']" exit_code: 1 Full output:
http://queues.webkit.org/results/7442014
WebKit Commit Bot
Comment 3
2011-01-08 14:38:03 PST
Comment on
attachment 78223
[details]
Proposed patch Rejecting
attachment 78223
[details]
from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'apply-attachment', '--no-update', '--non-interactive', 78223]" exit_code: 2 Last 500 characters of output: s/Pen.cpp' patching file Source/WebCore/platform/graphics/Pen.h rm 'Source/WebCore/platform/graphics/Pen.h' patching file Source/WebCore/platform/graphics/haiku/GraphicsContextHaiku.cpp patching file Source/WebCore/platform/graphics/wx/GraphicsContextWx.cpp patching file Source/WebCore/platform/graphics/wx/PenWx.cpp rm 'Source/WebCore/platform/graphics/wx/PenWx.cpp' Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Darin Adler', u'--force']" exit_code: 1 Full output:
http://queues.webkit.org/results/7379049
Andreas Kling
Comment 4
2011-01-10 00:35:31 PST
Committed
r75363
: <
http://trac.webkit.org/changeset/75363
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug