Bug 49952 - First steps to adding web audio files to build systems
Summary: First steps to adding web audio files to build systems
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-22 18:32 PST by Chris Rogers
Modified: 2010-12-03 12:05 PST (History)
9 users (show)

See Also:


Attachments
Patch (3.40 KB, patch)
2010-11-22 18:36 PST, Chris Rogers
no flags Details | Formatted Diff | Diff
Patch (21.95 KB, patch)
2010-11-30 14:32 PST, Chris Rogers
no flags Details | Formatted Diff | Diff
Patch (23.35 KB, patch)
2010-11-30 15:09 PST, Chris Rogers
no flags Details | Formatted Diff | Diff
Patch (24.01 KB, patch)
2010-12-01 13:01 PST, Chris Rogers
no flags Details | Formatted Diff | Diff
Patch (25.12 KB, patch)
2010-12-01 13:26 PST, Chris Rogers
no flags Details | Formatted Diff | Diff
Patch (20.72 KB, patch)
2010-12-02 11:52 PST, Chris Rogers
kbr: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rogers 2010-11-22 18:32:28 PST
Add AudioContext constructor to DOMWindow.idl
Comment 1 Chris Rogers 2010-11-22 18:36:03 PST
Created attachment 74624 [details]
Patch
Comment 2 WebKit Review Bot 2010-11-22 18:46:19 PST
Attachment 74624 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/6365008
Comment 3 Early Warning System Bot 2010-11-22 18:50:01 PST
Attachment 74624 [details] did not build on qt:
Build output: http://queues.webkit.org/results/6357010
Comment 4 Eric Seidel (no email) 2010-11-22 19:13:24 PST
Attachment 74624 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/6357012
Comment 5 WebKit Review Bot 2010-11-22 19:21:04 PST
Attachment 74624 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/6385007
Comment 6 Chris Rogers 2010-11-22 20:03:39 PST
Comment on attachment 74624 [details]
Patch

Still needs some more work to iron out build issues.
Comment 7 Chris Rogers 2010-11-30 14:32:06 PST
Created attachment 75204 [details]
Patch
Comment 8 Chris Rogers 2010-11-30 14:33:44 PST
Still not quite ready, and some of this can probably be split out into a separate patch, but I'd like to see how the buildbots react...
Comment 9 Early Warning System Bot 2010-11-30 14:44:43 PST
Attachment 75204 [details] did not build on qt:
Build output: http://queues.webkit.org/results/6409104
Comment 10 Chris Rogers 2010-11-30 15:09:41 PST
Created attachment 75212 [details]
Patch
Comment 11 Early Warning System Bot 2010-11-30 16:10:55 PST
Attachment 75212 [details] did not build on qt:
Build output: http://queues.webkit.org/results/6395122
Comment 12 Andras Becsi 2010-12-01 09:35:15 PST
(In reply to comment #11)
> Attachment 75212 [details] did not build on qt:
> Build output: http://queues.webkit.org/results/6395122

Please add the idl files to WebCore.pri, or disable WEB_AUDIO on Qt by adding a

!contains(DEFINES, ENABLE_WEB_AUDIO=.): DEFINES += ENABLE_WEB_AUDIO=0

to WebCore/features.pri
Comment 13 Chris Rogers 2010-12-01 13:01:48 PST
Created attachment 75310 [details]
Patch
Comment 14 Chris Rogers 2010-12-01 13:03:15 PST
Andras, thanks for the tip.  I've uploaded a new patch to disable WEB_AUDIO for now on Qt.
Comment 15 Early Warning System Bot 2010-12-01 13:15:25 PST
Attachment 75310 [details] did not build on qt:
Build output: http://queues.webkit.org/results/6676007
Comment 16 Chris Rogers 2010-12-01 13:26:58 PST
Created attachment 75314 [details]
Patch
Comment 17 Chris Rogers 2010-12-01 13:27:55 PST
New patch also adds .idl files to WebCore.pri for Qt.
Comment 18 Andras Becsi 2010-12-01 15:24:33 PST
(In reply to comment #17)
> New patch also adds .idl files to WebCore.pri for Qt.

Thanks very much for doing that.

Seems that the generated sources from IDL do not have guards for web audio.

Is there a way to add ENABLE guards to an IDL file's includes?

The patch looks pretty straightforward altogether, however I'm not a reviewer.
Comment 19 Chris Rogers 2010-12-02 11:52:39 PST
Created attachment 75399 [details]
Patch
Comment 20 Chris Rogers 2010-12-02 11:55:30 PST
Andras, the IDL glue generation script could maybe be refined to handle this.  But, it's good to get the IDL files in the build systems.

This new patch removes the AudioContext changes since these were landed in a different patch:
http://trac.webkit.org/changeset/73174
Comment 21 Kenneth Russell 2010-12-02 15:11:25 PST
Comment on attachment 75399 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=75399&action=review

Looks good as much as can be determined without trying builds on all platforms. r=me with one issue addressed.

> WebCore/WebCore.gyp/WebCore.gyp:149
> +      '../platform/audio/win',

The mac and win include directories should be added in the OS-specific blocks further below this one.
Comment 22 WebKit Commit Bot 2010-12-02 22:17:16 PST
Comment on attachment 75399 [details]
Patch

Rejecting patch 75399 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'apply-attachment', '--force-clean', '--non-interactive', 75399]" exit_code: 2
Last 500 characters of output:
j
patching file WebCore/WebCore.pri
patching file WebCore/WebCore.pro
patching file WebCore/features.pri
patching file WebCore/ForwardingHeaders/wtf/Complex.h
patching file WebCore/WebCore.gyp/WebCore.gyp
patching file WebCore/bindings/js/JSDOMWindowCustom.cpp
patching file WebCore/page/DOMWindow.idl
patching file WebCore/platform/audio/HRTFElevation.cpp

Failed to run "[u'/Users/abarth/git/webkit-queue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Kenneth Russell', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/6716030
Comment 23 Chris Rogers 2010-12-03 12:05:43 PST
Committed r73283: <http://trac.webkit.org/changeset/73283>