Bug 49946 – [chromium] Implement Extensions3DChromium::getGraphicsResetStatusARB

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Alexey Marinichev]

This extension helps with lost context recovery.

[Alexey Marinichev]

Created attachment 74610 [details]
Patch

[Kenneth Russell]

Comment on attachment 74610 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=74610&action=review

This basically looks good but there's one minor semantic bug.

> WebKit/chromium/src/Extensions3DChromium.cpp:53
> +    return m_internal->isContextLost() ? GraphicsContext3D::CONTEXT_LOST_WEBGL : GraphicsContext3D::NO_ERROR;

This should be returning one of NO_ERROR, GUILTY_CONTEXT_RESET_ARB, INNOCENT_CONTEXT_RESET_ARB, or UNKNOWN_CONTEXT_RESET_ARB. Since it sounds like we can't make the determination yet it should probably be UNKNOWN_CONTEXT_RESET_ARB.

> WebKit/chromium/src/WebGraphicsContext3DDefaultImpl.cpp:992
> +    return false;

Should we add a FIXME to implement this?

[Alexey Marinichev]

Created attachment 74611 [details]
changed CONTEXT_LOST_WEBGL to UNKNOWN_CONTEXT_RESET_ARB

[Kenneth Russell]

Comment on attachment 74611 [details]
changed CONTEXT_LOST_WEBGL to UNKNOWN_CONTEXT_RESET_ARB

Looks good.

[Kenneth Russell]

Comment on attachment 74611 [details]
changed CONTEXT_LOST_WEBGL to UNKNOWN_CONTEXT_RESET_ARB

Apparently there's a build failure with this version of the patch. Attempting to get it out of the commit queue (though hopefully it will just be rejected).

[Alexey Marinichev]

Created attachment 74613 [details]
fix build break

[Kenneth Russell]

Comment on attachment 74613 [details]
fix build break

OK.

[WebKit Commit Bot]

Comment on attachment 74613 [details]
fix build break

Clearing flags on attachment: 74613

Committed r72587: <http://trac.webkit.org/changeset/72587>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.