Bug 49930 - [chromium] Send didActivateAcceleratedCompositing when compositor initializes from existing shared context
Summary: [chromium] Send didActivateAcceleratedCompositing when compositor initializes...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nat Duca
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-22 12:18 PST by Nat Duca
Modified: 2010-11-22 22:05 PST (History)
3 users (show)

See Also:

Attachments
Proposed fix (1.60 KB, patch)
2010-11-22 12:25 PST, Nat Duca 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nat Duca 2010-11-22 12:18:41 PST 
Fixes Chrome bug http://code.google.com/p/chromium/issues/detail?id=64096
Comment 1 Nat Duca 2010-11-22 12:25:55 PST 
Created attachment 74585 [details]
Proposed fix

This bug occurs on WebGL content because it initializes the shared graphics context before the compositor. The compositor then turns on in WebViewImpl but forgets to tell the RenderWidget that compositor is turned on. RenderWidget proceeds to draw as if the page was software rendered.
Comment 2 Kenneth Russell 2010-11-22 12:40:13 PST 
Comment on attachment 74585 [details]
Proposed fix

Looks OK.
Comment 3 WebKit Commit Bot 2010-11-22 22:04:03 PST 
The commit-queue encountered the following flaky tests while processing attachment 74585 [details]:

java/lc3/JSObject/ToObject-001.html

Please file bugs against the tests.  These tests were authored by ap@webkit.org.  The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2010-11-22 22:05:20 PST 
Comment on attachment 74585 [details]
Proposed fix

Clearing flags on attachment: 74585

Committed r72584: <http://trac.webkit.org/changeset/72584>
Comment 5 WebKit Commit Bot 2010-11-22 22:05:25 PST 
All reviewed patches have been landed.  Closing bug.