Bug 49919 - [Qt] GraphicsContext: Clean up Qt/WebCore type conversion functions
Summary: [Qt] GraphicsContext: Clean up Qt/WebCore type conversion functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Renata Hodovan
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2010-11-22 09:35 PST by Andreas Kling
Modified: 2010-11-24 07:49 PST (History)
0 users

See Also:

Attachments
Patch (2.64 KB, patch)
2010-11-24 06:57 PST, Renata Hodovan 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2010-11-22 09:35:57 PST 
There are a bunch of conversion functions between Qt and WebCore types at the top of GraphicsContext.cpp

All cases should be handled in all functions, instead of having a qWarning() and returning some arbitrary "sane default".

Also, Qt::MiterJoin shouldn't be used anywhere (it's currently impossibly returned by toQtLineJoin().)
Comment 1 Renata Hodovan 2010-11-24 06:57:34 PST 
Created attachment 74755 [details]
Patch
Comment 2 Andreas Kling 2010-11-24 06:58:56 PST 
Comment on attachment 74755 [details]
Patch

LGTM
Comment 3 Andreas Kling 2010-11-24 07:49:23 PST 
Landed in <http://trac.webkit.org/changeset/72668>