Bug 49916 - [Qt] Leak with GraphicsContext::takeOwnershipOfPlatformContext()
Summary: [Qt] Leak with GraphicsContext::takeOwnershipOfPlatformContext()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Renata Hodovan
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2010-11-22 09:24 PST by Andreas Kling
Modified: 2010-11-30 08:03 PST (History)
0 users

See Also:

Attachments
Patch (1.28 KB, patch)
2010-11-29 04:43 PST, Renata Hodovan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2010-11-22 09:24:27 PST 
The GraphicsContextPlatformPrivate destructor currently calls QPainter::end() before deleting the paint device.

QPainter::device() will always return 0 after calling end(), so this code is leaking the device.
Comment 1 Renata Hodovan 2010-11-29 04:43:02 PST 
Created attachment 75016 [details]
Patch
Comment 2 Renata Hodovan 2010-11-30 05:41:40 PST 
This is landed in <http://trac.webkit.org/changeset/72907>.
Comment 3 Balazs Kelemen 2010-11-30 07:58:23 PST 
Comment on attachment 75016 [details]
Patch

Clearing flags. Please do not forget
it next time! ;)
Comment 4 Renata Hodovan 2010-11-30 08:03:22 PST 
(In reply to comment #3)
> (From update of attachment 75016 [details])
> Clearing flags. Please do not forget
> it next time! ;)

Thank you very much ;)