[GTK] Inspector: add a way to inspect a WebKitDOMNode

[Carlos Garcia Campos]

Add API to WebKitWebInspector to inspect a node.

[Carlos Garcia Campos]

Created attachment 74539 [details]
Add webkit_web_inspector_inspect()

[Martin Robinson]

Seems reasonable to me. Maybe webkit_web_inspector_inspect_node? We'll need one or two more GTK+ reviewers to approve the API change.

[Xan Lopez]

Comment on attachment 74539 [details]
Add webkit_web_inspector_inspect()

View in context: https://bugs.webkit.org/attachment.cgi?id=74539&action=review

> WebKit/gtk/webkit/webkitwebinspector.cpp:504
> + * @web_inspector: the #WebKitWebInspector that will do the inspection

inspect_node would be better, I agree with Martin.

> WebKit/gtk/webkit/webkitwebinspector.h:26
>  #include <webkit/webkitdefines.h>

You shouldn't include the whole dom header just to use WebKitDOMNode*. Including webkitdomdefines.h should be enough, I think.

[Carlos Garcia Campos]

Created attachment 74838 [details]
Updated patch using inspect_node() and fixing includes

[WebKit Commit Bot]

Comment on attachment 74838 [details]
Updated patch using inspect_node() and fixing includes

Clearing flags on attachment: 74838

Committed r72772: <http://trac.webkit.org/changeset/72772>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.