RESOLVED FIXED 49895
Add lastModifiedDate attribute to File interface per File API spec 
https://bugs.webkit.org/show_bug.cgi?id=49895
Summary Add lastModifiedDate attribute to File interface per File API spec
Jian Li
Reported 2010-11-21 20:06:35 PST
Add lastModifiedDate attribute to File interface per File API spec:
Attachments
Proposed Patch (6.30 KB, patch)
2010-11-21 20:39 PST, Jian Li 		jianli: commit-queue-
DetailsFormatted DiffDiff
Proposed Patch (6.47 KB, patch)
2010-11-21 21:15 PST, Jian Li 		jianli: commit-queue-
DetailsFormatted DiffDiff
Proposed Patch (6.48 KB, patch)
2010-11-21 21:47 PST, Jian Li 		levin: review+
jianli: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jian Li
Comment 1 2010-11-21 20:39:41 PST
Created attachment 74527 [details] Proposed Patch
WebKit Review Bot
Comment 2 2010-11-21 20:51:14 PST
Attachment 74527 [details] did not build on gtk: Build output: http://queues.webkit.org/results/6251084
Jian Li
Comment 3 2010-11-21 21:15:11 PST
Created attachment 74529 [details] Proposed Patch Fixed gtk error.
WebKit Review Bot
Comment 4 2010-11-21 21:24:00 PST
Attachment 74529 [details] did not build on gtk: Build output: http://queues.webkit.org/results/6165136
Jian Li
Comment 5 2010-11-21 21:47:11 PST
Created attachment 74530 [details] Proposed Patch
Jarred Nicholls
Comment 6 2010-12-12 22:38:46 PST
The spec calls for lastModifiedDate to be a DOMString, not a Date. It wants a "valid date string": http://dev.w3.org/html5/spec/Overview.html#valid-date-string Or in otherwords, YYYY-MM-DD
Jian Li
Comment 7 2010-12-20 13:38:13 PST
(In reply to comment #6) > The spec calls for lastModifiedDate to be a DOMString, not a Date. It wants a "valid date string": > > http://dev.w3.org/html5/spec/Overview.html#valid-date-string > > Or in otherwords, YYYY-MM-DD The spec has just been updated with a Date object returned for File.lastModifiedData. http://dev.w3.org/2006/webapi/FileAPI/#dfn-lastModifiedDate
Jarred Nicholls
Comment 8 2010-12-20 13:41:00 PST
(In reply to comment #7) > (In reply to comment #6) > > The spec calls for lastModifiedDate to be a DOMString, not a Date. It wants a "valid date string": > > > > http://dev.w3.org/html5/spec/Overview.html#valid-date-string > > > > Or in otherwords, YYYY-MM-DD > > The spec has just been updated with a Date object returned for File.lastModifiedData. > http://dev.w3.org/2006/webapi/FileAPI/#dfn-lastModifiedDate Indeed, good. When will that be the latest published version you think?
Jian Li
Comment 9 2010-12-20 17:36:33 PST
(In reply to comment #8) > (In reply to comment #7) > > (In reply to comment #6) > > > The spec calls for lastModifiedDate to be a DOMString, not a Date. It wants a "valid date string": > > > > > > http://dev.w3.org/html5/spec/Overview.html#valid-date-string > > > > > > Or in otherwords, YYYY-MM-DD > > > > The spec has just been updated with a Date object returned for File.lastModifiedData. > > http://dev.w3.org/2006/webapi/FileAPI/#dfn-lastModifiedDate > > Indeed, good. When will that be the latest published version you think? Please ping the spec editor about this. Thanks.
Jian Li
Comment 10 2010-12-20 18:22:49 PST
Committed as http://trac.webkit.org/changeset/74380.
WebKit Review Bot
Comment 11 2010-12-20 19:10:43 PST
http://trac.webkit.org/changeset/74380 might have broken GTK Linux 64-bit Debug
Note You need to log in before you can comment on or make changes to this bug.