Bug 49894 - Remove StringImpl::computeHash()
Summary: Remove StringImpl::computeHash()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on: 49893 52934
Blocks:
  Show dependency tree / graph
 
Reported: 2010-11-21 18:50 PST by Patrick R. Gansterer
Modified: 2011-03-19 17:57 PDT (History)
7 users (show)

See Also:

Attachments
Patch (9.57 KB, patch)
2010-11-21 19:18 PST, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
Patch (3.88 KB, patch)
2011-03-19 05:06 PDT, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2010-11-21 18:50:22 PST 
see patch
Comment 1 Patrick R. Gansterer 2010-11-21 19:18:04 PST 
Created attachment 74525 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-11-21 19:32:19 PST 
Attachment 74525 [details] did not build on mac:
Build output: http://queues.webkit.org/results/6255090
Comment 3 Early Warning System Bot 2010-11-21 19:38:42 PST 
Attachment 74525 [details] did not build on qt:
Build output: http://queues.webkit.org/results/6276042
Comment 4 WebKit Review Bot 2010-11-21 19:53:27 PST 
Attachment 74525 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/6187110
Comment 5 Build Bot 2010-11-21 23:54:54 PST 
Attachment 74525 [details] did not build on win:
Build output: http://queues.webkit.org/results/6218122
Comment 6 Eric Seidel (no email) 2010-11-22 09:07:29 PST 
It seems you should CC some of the original authors. Webkit patch's suggest-reviewers functions can help with that.
Comment 7 Eric Seidel (no email) 2010-12-12 02:41:19 PST 
Comment on attachment 74525 [details]
Patch

Does not compile.
Comment 8 Patrick R. Gansterer 2011-03-19 05:06:06 PDT 
Created attachment 86260 [details]
Patch
Comment 9 WebKit Review Bot 2011-03-19 05:09:11 PDT 
Attachment 86260 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/wtf/text/StringImpl.h:238:  More than one command on the same line in if  [whitespace/parens] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 WebKit Commit Bot 2011-03-19 17:57:22 PDT 
Comment on attachment 86260 [details]
Patch

Clearing flags on attachment: 86260

Committed r81563: <http://trac.webkit.org/changeset/81563>
Comment 11 WebKit Commit Bot 2011-03-19 17:57:28 PDT 
All reviewed patches have been landed.  Closing bug.