Bug 49882 – Use WTF_ARRAY_LENGTH in WebCore directory

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Patrick R. Gansterer]

see patch

[Patrick R. Gansterer]

Created attachment 74507 [details]
Patch

[WebKit Review Bot]

Attachment 74507 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/6274043

[Early Warning System Bot]

Attachment 74507 [details] did not build on qt:
Build output: http://queues.webkit.org/results/6246088

[Patrick R. Gansterer]

Created attachment 74508 [details]
Patch

[Eric Seidel (no email)]

Attachment 74507 [details] did not build on mac:
Build output: http://queues.webkit.org/results/6246089

[WebKit Review Bot]

Attachment 74507 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/6128104

[WebKit Review Bot]

Attachment 74508 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/6217127

[Build Bot]

Attachment 74507 [details] did not build on win:
Build output: http://queues.webkit.org/results/6118106

[Early Warning System Bot]

Attachment 74508 [details] did not build on qt:
Build output: http://queues.webkit.org/results/6144106

[Patrick R. Gansterer]

Created attachment 74509 [details]
Patch

[WebKit Review Bot]

Attachment 74508 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/6257080

[Patrick R. Gansterer]

Created attachment 74510 [details]
Patch

[Eric Seidel (no email)]

Attachment 74507 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/6164119

[Eric Seidel (no email)]

Attachment 74508 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/6141110

[Csaba Osztrogonác]

Comment on attachment 74510 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=74510&action=review

> WebCore/html/canvas/WebGLBuffer.cpp:182
> +    size_t numEntries = WTF_ARRAY_LENGTH(m_maxIndexCache);
> +    for (size_t i = 0; i < numEntries; ++i)

We don't need numEntries variable here. Please fix this before landing:
for (size_t i = 0; i < WTF_ARRAY_LENGTH(m_maxIndexCache); ++i)

Otherwise LGTM.

[Patrick R. Gansterer]

Comment on attachment 74510 [details]
Patch

(In reply to comment #15)
> (From update of attachment 74510 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=74510&action=review
> 
> > WebCore/html/canvas/WebGLBuffer.cpp:182
> > +    size_t numEntries = WTF_ARRAY_LENGTH(m_maxIndexCache);
> > +    for (size_t i = 0; i < numEntries; ++i)
> 
> We don't need numEntries variable here. Please fix this before landing:
> for (size_t i = 0; i < WTF_ARRAY_LENGTH(m_maxIndexCache); ++i)
> 
> Otherwise LGTM.
I removed numEntries in a first version, but the compiled said NO ;-)
It's used in http://trac.webkit.org/browser/trunk/WebCore/html/canvas/WebGLBuffer.cpp?rev=68424#L190.

[Csaba Osztrogonác]

(In reply to comment #16)
> I removed numEntries in a first version, but the compiled said NO ;-)
> It's used in http://trac.webkit.org/browser/trunk/WebCore/html/canvas/WebGLBuffer.cpp?rev=68424#L190.

Ooops, you're right. :)

[WebKit Commit Bot]

Comment on attachment 74510 [details]
Patch

Clearing flags on attachment: 74510

Committed r72500: <http://trac.webkit.org/changeset/72500>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.