Bug 49870 - [Qt] Dragging a selection should use a rendering of the selection as "cursor" for the drag
Summary: [Qt] Dragging a selection should use a rendering of the selection as "cursor"...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: QtWebKit Unassigned
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks: 49872
  Show dependency tree / graph
 
Reported: 2010-11-20 14:52 PST by Andreas Kling
Modified: 2010-11-20 22:57 PST (History)
3 users (show)

See Also:

Attachments
Proposed patch (4.75 KB, patch)
2010-11-20 15:03 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2010-11-20 14:52:14 PST 
We need to implement Frame::dragImageForSelection() and hook it up in DragClientQt::startDrag()
Comment 1 Andreas Kling 2010-11-20 15:03:00 PST 
Created attachment 74488 [details]
Proposed patch
Comment 2 Antonio Gomes 2010-11-20 22:28:22 PST 
Comment on attachment 74488 [details]
Proposed patch

r=me. 

I assume it can't be tested :(
Comment 3 Andreas Kling 2010-11-20 22:33:56 PST 
(In reply to comment #2)
> I assume it can't be tested :(

Indeed ;( But thanks for reviewing!
Comment 4 Andreas Kling 2010-11-20 22:36:45 PST 
Comment on attachment 74488 [details]
Proposed patch

Clearing flags on attachment: 74488

Committed r72494: <http://trac.webkit.org/changeset/72494>
Comment 5 Andreas Kling 2010-11-20 22:36:55 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Review Bot 2010-11-20 22:57:51 PST 
http://trac.webkit.org/changeset/72494 might have broken Qt Linux Release
The following tests are not passing:
fast/events/tabindex-focus-blur-all.html