Bug 49860 – CSS style rules don't GC protect objects reachable as their properties

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Alexey Proskuryakov]

E.g. CSSStyleRule.style.

[Alexey Proskuryakov]

Created attachment 74470 [details]
work in progress

[Alexey Proskuryakov]

Created attachment 74471 [details]
proposed fix

[Early Warning System Bot]

Attachment 74471 [details] did not build on qt:
Build output: http://queues.webkit.org/results/6134073

[Alexey Proskuryakov]

Created attachment 74472 [details]
proposed fix

With Qt build fix.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 74472 [details]:

compositing/iframes/overlapped-nested-iframes.html
fast/workers/storage/use-same-database-in-page-and-workers.html

Please file bugs against the tests.  These tests were authored by [e-mail] and [e-mail].  The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 74472 [details]:

fast/profiler/throw-exception-from-eval.html
fast/workers/storage/use-same-database-in-page-and-workers.html

Please file bugs against the tests.  These tests were authored by [e-mail], [e-mail], [e-mail], and [e-mail].  The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 74472 [details]
proposed fix

Rejecting patch 74472 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build-and-test', '--no-clean', '--no-update', '--test', '--non-interactive']" exit_code: 2
Last 500 characters of output:

..................................................................................
compositing .........
compositing/animation ...
compositing/color-matching ..
compositing/geometry ............................
compositing/iframes ......................
compositing/iframes/overlapped-nested-iframes.html -> failed

Exiting early after 1 failures. 1001 tests run.
75.58s total testing time

1000 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
2 test cases (<1%) had stderr output

Full output: http://queues.webkit.org/results/6353001

[WebKit Commit Bot]

Comment on attachment 74472 [details]
proposed fix

Rejecting patch 74472 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'apply-attachment', '--force-clean', '--non-interactive', 74472]" exit_code: 2
Last 500 characters of output:
e WebCore/css/CSSStyleRule.idl
patching file WebCore/css/WebKitCSSKeyframeRule.idl
patching file WebCore/css/WebKitCSSKeyframesRule.idl
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/fast/dom/StyleSheet/gc-rule-children-wrappers-expected.txt
patching file LayoutTests/fast/dom/StyleSheet/gc-rule-children-wrappers.html

Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Darin Adler', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/6382004

[Alexey Proskuryakov]

Committed <http://trac.webkit.org/changeset/72590>.