Add a mechanism for Windows pre-build/pre-link/post-build events to be separated into individual cmd files
Created attachment 74467 [details] Patch
Comment on attachment 74467 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=74467&action=review The changes looks good, just think the ChangeLog could use a little more information for other people wanting to move scripts into their own files. > JavaScriptCore/ChangeLog:6 > + Add a mechanism for Windows pre-build/pre-link/post-build events to be separated into individual cmd files > + https://bugs.webkit.org/show_bug.cgi?id=49858 It might be nice here to talk a little more about how other projects create/adopt these new cmd files (create them next to the vsprops files, with the correct names (ProjectName + Pre/Post + Build/Link).
Comment on attachment 74467 [details] Patch I agree with Brian's comments. It's weird that WTF doesn't have a pre-build event. Maybe that's a relic from when it (instead of JavaScriptCoreGenerated) was the first project?
Committed r72846: <http://trac.webkit.org/changeset/72846>