Bug 49858 - Add a mechanism for Windows pre-build/pre-link/post-build events to be separated into individual cmd files
Summary: Add a mechanism for Windows pre-build/pre-link/post-build events to be separa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Steve Falkenburg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-19 22:21 PST by Steve Falkenburg
Modified: 2010-11-29 16:10 PST (History)
1 user (show)

See Also:


Attachments
Patch (5.78 KB, patch)
2010-11-19 22:25 PST, Steve Falkenburg
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Falkenburg 2010-11-19 22:21:21 PST
Add a mechanism for Windows pre-build/pre-link/post-build events to be separated into individual cmd files
Comment 1 Steve Falkenburg 2010-11-19 22:25:21 PST
Created attachment 74467 [details]
Patch
Comment 2 Brian Weinstein 2010-11-22 10:45:27 PST
Comment on attachment 74467 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=74467&action=review

The changes looks good, just think the ChangeLog could use a little more information for other people wanting to move scripts into their own files.

> JavaScriptCore/ChangeLog:6
> +        Add a mechanism for Windows pre-build/pre-link/post-build events to be separated into individual cmd files
> +        https://bugs.webkit.org/show_bug.cgi?id=49858

It might be nice here to talk a little more about how other projects create/adopt these new cmd files (create them next to the vsprops files, with the correct names (ProjectName + Pre/Post + Build/Link).
Comment 3 Adam Roben (:aroben) 2010-11-22 10:46:45 PST
Comment on attachment 74467 [details]
Patch

I agree with Brian's comments.

It's weird that WTF doesn't have a pre-build event. Maybe that's a relic from when it (instead of JavaScriptCoreGenerated) was the first project?
Comment 4 Steve Falkenburg 2010-11-29 16:10:46 PST
Committed r72846: <http://trac.webkit.org/changeset/72846>