Bug 49819 - Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
Summary: Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Steve Falkenburg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-19 12:36 PST by Steve Falkenburg
Modified: 2010-11-19 17:15 PST (History)
2 users (show)

See Also:


Attachments
Patch (94.83 KB, patch)
2010-11-19 12:39 PST, Steve Falkenburg
no flags Details | Formatted Diff | Diff
Patch (171.40 KB, patch)
2010-11-19 15:19 PST, Steve Falkenburg
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Falkenburg 2010-11-19 12:36:04 PST
Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
Comment 1 Steve Falkenburg 2010-11-19 12:39:51 PST
Created attachment 74415 [details]
Patch
Comment 2 Steve Falkenburg 2010-11-19 12:41:11 PST
Comment on attachment 74415 [details]
Patch

Patch is incorrect. Not ready for review yet.
Comment 3 Steve Falkenburg 2010-11-19 15:19:19 PST
Created attachment 74430 [details]
Patch
Comment 4 Adam Roben (:aroben) 2010-11-19 16:58:13 PST
Comment on attachment 74430 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=74430&action=review

> WebKit2/win/WebKit2WebProcessCommon.vsprops:14
>  		AdditionalDependencies="WebKit$(WebKitDLLConfigSuffix).lib"
> +    AdditionalOptions="/NXCOMPAT"

Screwy indentation here.

> WebKit/win/WebKit.vcproj/WebKitGUID.vcproj:252
> +				Name="VCMIDLTool"
> +				OutputDirectory="Release"

Is the OutputDirectory needed?
Comment 5 Steve Falkenburg 2010-11-19 17:15:41 PST
Committed r72454: <http://trac.webkit.org/changeset/72454>