Bug 49814 - Don't check for constant registers when we can guarantee that the register won't be in the constant pool
Summary: Don't check for constant registers when we can guarantee that the register wo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-19 11:02 PST by Oliver Hunt
Modified: 2010-11-19 14:44 PST (History)
1 user (show)

See Also:


Attachments
Patch (62.90 KB, patch)
2010-11-19 11:08 PST, Oliver Hunt
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2010-11-19 11:02:41 PST
Don't check for constant registers when we can guarantee that the register won't be in the constant pool
Comment 1 Oliver Hunt 2010-11-19 11:08:27 PST
Created attachment 74405 [details]
Patch
Comment 2 Darin Adler 2010-11-19 11:25:27 PST
Comment on attachment 74405 [details]
Patch

Don’t we want an assertion in debug builds?
Comment 3 Geoffrey Garen 2010-11-19 12:38:19 PST
+        Add uncheckedR(int) to CallFrame, and replace all the uses of r() with uncheckedR().

You didn't replace all uses -- just the known non-constant uses.
Comment 4 Geoffrey Garen 2010-11-19 12:38:38 PST
Comment on attachment 74405 [details]
Patch

r=me on a patch that fixes these two issues.
Comment 5 Oliver Hunt 2010-11-19 14:44:19 PST
Committed r72442: <http://trac.webkit.org/changeset/72442>