RESOLVED FIXED 49814
Don't check for constant registers when we can guarantee that the register won't be in the constant pool 
https://bugs.webkit.org/show_bug.cgi?id=49814
Summary Don't check for constant registers when we can guarantee that the register wo...
Oliver Hunt
Reported 2010-11-19 11:02:41 PST
Don't check for constant registers when we can guarantee that the register won't be in the constant pool
Attachments
Patch (62.90 KB, patch)
2010-11-19 11:08 PST, Oliver Hunt 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2010-11-19 11:08:27 PST
Created attachment 74405 [details] Patch
Darin Adler
Comment 2 2010-11-19 11:25:27 PST
Comment on attachment 74405 [details] Patch Don’t we want an assertion in debug builds?
Geoffrey Garen
Comment 3 2010-11-19 12:38:19 PST
+ Add uncheckedR(int) to CallFrame, and replace all the uses of r() with uncheckedR(). You didn't replace all uses -- just the known non-constant uses.
Geoffrey Garen
Comment 4 2010-11-19 12:38:38 PST
Comment on attachment 74405 [details] Patch r=me on a patch that fixes these two issues.
Oliver Hunt
Comment 5 2010-11-19 14:44:19 PST
Committed r72442: <http://trac.webkit.org/changeset/72442>
Note You need to log in before you can comment on or make changes to this bug.