Bug 49795 – [GTK] Response created on redirects must have the url of the initial request

• Status: UNCONFIRMED
• Component: WebKitGTK

[Sergio Villar Senin]

The current code in restartedCallback (ResourceHandleSoup.cpp) creates a new ResourceResponse based on the SoupMessage returned by libsoup. libsoup does replace the original url of the SoupMessage by the new location especified by the redirect received by the server.

As could be seen in the other ports (for example ResourceHandleWin.cpp:176), that response must have the url of the original request. That is confirmed by the expected results of LayoutTests/http/tests/loading/redirect-methods.html

[Sergio Villar Senin]

Created attachment 74372 [details]
Proposed fix

[Xan Lopez]

So do we pass that test with this patch or not?

[Sergio Villar Senin]

Not yet because there are several signals needed by the DRT that we'd have to implement. Some of them are being implemented https://bugs.webkit.org/show_bug.cgi?id=49543 (those patches are a bit outdated but I'll upload new versions soon)

What I checked is that with those new signals and this patch, the gap between the expected and actual results shortens

[Martin Robinson]

For now, would it possible to create some platform specific results for the failing test and then remove them when the frame loader signals are implemented? I think it's better to include test results with the patch.

[Xan Lopez]

Comment on attachment 74372 [details]
Proposed fix

Agreed with Martin, let's just generate some results to show this is working and we can get rid of them later when we have all the pieces in place.