RESOLVED WORKSFORME4979
Entity references not dereferenced in <style>, style= 
https://bugs.webkit.org/show_bug.cgi?id=4979
Summary Entity references not dereferenced in <style>, style=
Mac-arena the Bored Zo
Reported 2005-09-14 03:35:40 PDT
current behaviour: entity references are always passed raw to the CSS parser, even when embedded in XML (using the <style> element or style= attribute). for example, when the entity reference &x2318; is placed in a <style>, the CSS parser receives and acts on an ampersand, followed by a Latin small letter x, etc, rather than as the place of interest sign. correct behaviour: entity references in these places should be dereferenced before passing them to the CSS parser (so that "&x2318;" is passed to the CSS parser as place of interest sign). the current behaviour is correct for external CSS files, where entity references do not exist; this is only a bug for CSS embedded in an XML document. I call this a bug on the grounds that as far as XML is concerned, it's just character data.
Attachments
crash log for ToT (75.23 KB, text/plain)
2005-09-14 21:46 PDT, Alexey Proskuryakov 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2005-09-14 10:20:36 PDT
Should this actually work? I am not convinced that it should. Does it work in Firefox?
Dave Hyatt
Comment 2 2005-09-14 10:21:24 PDT
(Note that entities are broken in all of XML right now, and not just in <style>. This is probably the bug you're running into actually.)
Alexey Proskuryakov
Comment 3 2005-09-14 12:22:03 PDT
Is the lack of '#' after an ampersand just a typo, or I'm missing something?
Mac-arena the Bored Zo
Comment 4 2005-09-14 21:19:26 PDT
in reverse order: typo in the bug description. the # was present in the HTML file I used to test it: &#x2318; I'm using 10.4.2 release, not HEAD, so bugs in the CVS WebKit do not affect me. I'm updating my CVS WebKit right now, for the first time in a few months I do not use Firefox.
Alexey Proskuryakov
Comment 5 2005-09-14 21:46:37 PDT
Created attachment 3896 [details] crash log for ToT
Alexey Proskuryakov
Comment 6 2005-09-14 21:47:27 PDT
(In reply to comment #5) Sorry, that's from another bug.
Mac-arena the Bored Zo
Comment 7 2005-09-15 01:20:59 PDT
confirmed in CVS as of end-of-day, 2005-09-15, PDT.
Eric Seidel (no email)
Comment 8 2005-12-28 00:55:17 PST
Comment on attachment 3896 [details] crash log for ToT I don't think this has anything to do with this bug.
Eric Seidel (no email)
Comment 9 2005-12-28 00:57:21 PST
This will need a test case demonstrating the problem. There are also other entity related bugs like http:// bugzilla.opendarwin.org/show_bug.cgi?id=4301 which might actually be causing this. Entities should be substituted for inline script tags (if I'm remembering correctly). But they will *not* be substituted in external css files. A good test case will clear up what you meant above.
Joost de Valk (AlthA)
Comment 10 2005-12-28 06:57:38 PST
This IS done correctly in ToT, as shown here: http://dev.outbreak.nl/webkit/entity-referencing-style.php. Closing this bug as worksforme.
Joost de Valk (AlthA)
Comment 11 2005-12-28 07:23:20 PST
url in comment above should be: http://dev.outbreak.nl/webkit/entity-referencing-style.xhtml
Note You need to log in before you can comment on or make changes to this bug.