Bug 49767 – Make sure is* return false if the name is never bound

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Zhenyao Mo]

For texture, buffer, renderbuffer, framebuffer.

So we can work around this driver bug and pass enne's conformance test.

[Zhenyao Mo]

Created attachment 74324 [details]
patch

[Zhenyao Mo]

The is-object.html test is already checked in and marked as a failure.  Once this lands and the bots results confirm the test passing, I'll remove the entry from the test_expectations and skipped.

[Zhenyao Mo]

Created attachment 74325 [details]
revised patch

Remove the "No new tests. (OOPS!)" from change log.

[Adrienne Walker]

Ah, good thought.  If we fix this in WebKit, then we don't have to worry about incorrect drivers.

[Kenneth Russell]

Comment on attachment 74325 [details]
revised patch

View in context: https://bugs.webkit.org/attachment.cgi?id=74325&action=review

The naming convention for these new methods is poor. The general rule is to name methods so clearly that comments aren't needed. This is especially true in a case like this where the methods are so simple.

> WebCore/html/canvas/WebGLBuffer.h:62
> +    bool bound() const { return object() && m_target; }

bool hasEverBeenBound() const

> WebCore/html/canvas/WebGLFramebuffer.h:59
> +    // Return false if it is never bound; otherwise return true.

Useless comment.

> WebCore/html/canvas/WebGLFramebuffer.h:60
> +    bool bound() const { return object() && m_bound; }

bool hasEverBeenBound() const

> WebCore/html/canvas/WebGLFramebuffer.h:62
> +    void setBound() { m_bound = true; }

void setHasEverBeenBound()

> WebCore/html/canvas/WebGLRenderbuffer.h:63
> +    // Return false if it is never bound; otherwise return true.

Useless comment.

> WebCore/html/canvas/WebGLRenderbuffer.h:66
> +    bool bound() const { return object() && m_bound; }
> +
> +    void setBound() { m_bound = true; }

Naming.

> WebCore/html/canvas/WebGLTexture.h:64
> +    bool bound() const { return object() && m_target; }

bool hasEverBeenBound()

[Zhenyao Mo]

Created attachment 74418 [details]
revised patch: naming fix

[Zhenyao Mo]

Created attachment 74420 [details]
revised patch

[Kenneth Russell]

Comment on attachment 74420 [details]
revised patch

Thanks, looks better.

[Zhenyao Mo]

Committed r72433: <http://trac.webkit.org/changeset/72433>