Bug 49765 - [Qt] Memory leak in QWebInspector
Summary: [Qt] Memory leak in QWebInspector
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P3 Normal
Assignee: Yi Shen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-18 15:22 PST by Yi Shen
Modified: 2010-11-19 21:20 PST (History)
2 users (show)

See Also:

Attachments
first try (992 bytes, patch)
2010-11-18 15:28 PST, Yi Shen 		no flags Details | Formatted Diff | Diff
prevent double delete by QWebPagePrivate (1.06 KB, patch)
2010-11-18 15:44 PST, Yi Shen 		kling: review-
Details | Formatted Diff | Diff
remove unnecessary stuff (1004 bytes, patch)
2010-11-19 04:21 PST, Yi Shen 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yi Shen 2010-11-18 15:22:17 PST 
should delete QWebInspectorPrivate in ~QWebInspector()
Comment 1 Yi Shen 2010-11-18 15:28:26 PST 
Created attachment 74304 [details]
first try
Comment 2 Yi Shen 2010-11-18 15:44:36 PST 
Created attachment 74306 [details]
prevent double delete by QWebPagePrivate
Comment 3 Andreas Kling 2010-11-18 21:16:22 PST 
Comment on attachment 74306 [details]
prevent double delete by QWebPagePrivate

View in context: https://bugs.webkit.org/attachment.cgi?id=74306&action=review

Patch is fine, but:

> WebKit/qt/Api/qwebinspector.cpp:94
> +    if (d) {

Unnecessary if- "delete d" is a no-op if !d.

> WebKit/qt/Api/qwebinspector.cpp:96
> +        // Prevent double delete by QWebPagePrivate

Unnecessary comment.
Comment 4 Yi Shen 2010-11-19 04:21:49 PST 
Created attachment 74367 [details]
remove unnecessary stuff

Thanks Kling, u r right :)
Comment 5 Laszlo Gombos 2010-11-19 04:53:04 PST 
Comment on attachment 74367 [details]
remove unnecessary stuff

LGTM, r+.
Comment 6 WebKit Commit Bot 2010-11-19 21:20:39 PST 
Comment on attachment 74367 [details]
remove unnecessary stuff

Clearing flags on attachment: 74367

Committed r72466: <http://trac.webkit.org/changeset/72466>
Comment 7 WebKit Commit Bot 2010-11-19 21:20:44 PST 
All reviewed patches have been landed.  Closing bug.