Bug 49757 - Complete support for Unix editing mode
Summary: Complete support for Unix editing mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 23351
  Show dependency treegraph
 
Reported: 2010-11-18 13:08 PST by Avi Drissman
Modified: 2010-11-19 14:37 PST (History)
3 users (show)

See Also:


Attachments
Fix (3.84 KB, patch)
2010-11-18 13:14 PST, Avi Drissman
no flags Details | Formatted Diff | Diff
Fix try #2 (3.77 KB, patch)
2010-11-18 13:16 PST, Avi Drissman
no flags Details | Formatted Diff | Diff
Correct initialization order (4.89 KB, patch)
2010-11-18 13:34 PST, Avi Drissman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Avi Drissman 2010-11-18 13:08:21 PST
One bit isn't large enough to hold three values.
Comment 1 Avi Drissman 2010-11-18 13:14:43 PST
Created attachment 74282 [details]
Fix
Comment 2 Avi Drissman 2010-11-18 13:16:10 PST
Created attachment 74283 [details]
Fix try #2
Comment 3 Early Warning System Bot 2010-11-18 13:27:30 PST
Attachment 74283 [details] did not build on qt:
Build output: http://queues.webkit.org/results/6171059
Comment 4 Antonio Gomes 2010-11-18 13:29:11 PST
Comment on attachment 74283 [details]
Fix try #2

Yay!
Comment 5 Avi Drissman 2010-11-18 13:31:13 PST
QT builder has a point. Will fix.
Comment 6 Antonio Gomes 2010-11-18 13:31:35 PST
(In reply to comment #3)
> Attachment 74283 [details] did not build on qt:
> Build output: http://queues.webkit.org/results/6171059

cc1plus: warnings being treated as errors
../../../WebCore/page/Settings.h: In constructor 'WebCore::Settings::Settings(WebCore::Page*)':
../../../WebCore/page/Settings.h:409: error: 'WebCore::Settings::m_allowScriptsToCloseWindows' will be initialized after
../../../WebCore/page/Settings.h:361: error:   'unsigned int WebCore::Settings::m_editingBehaviorType'
../../../WebCore/page/Settings.cpp:88: error:   when initialized here

The initialization order matters.
Comment 7 Avi Drissman 2010-11-18 13:34:37 PST
Created attachment 74288 [details]
Correct initialization order

Yes, I realized this right after I'd uploaded the last one.
Comment 8 Eric Seidel (no email) 2010-11-19 05:45:09 PST
Comment on attachment 74283 [details]
Fix try #2

Cleared Antonio Gomes's review+ from obsolete attachment 74283 [details] so that this bug does not appear in http://webkit.org/pending-commit.
Comment 9 WebKit Commit Bot 2010-11-19 14:37:17 PST
Comment on attachment 74288 [details]
Correct initialization order

Clearing flags on attachment: 74288

Committed r72441: <http://trac.webkit.org/changeset/72441>
Comment 10 WebKit Commit Bot 2010-11-19 14:37:23 PST
All reviewed patches have been landed.  Closing bug.