RESOLVED FIXED49753
Debug_Internal Windows configuration is unnecessary, should be removed 
https://bugs.webkit.org/show_bug.cgi?id=49753
Summary Debug_Internal Windows configuration is unnecessary, should be removed
Steve Falkenburg
Reported 2010-11-18 11:40:17 PST
Debug_Internal Windows configuration is unnecessary, should be removed
Attachments
Patch (7.31 KB, patch)
2010-11-18 12:06 PST, Steve Falkenburg 		no flags
DetailsFormatted DiffDiff
Patch (7.28 KB, patch)
2010-11-18 12:09 PST, Steve Falkenburg 		aroben: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Steve Falkenburg
Comment 1 2010-11-18 12:06:23 PST
Created attachment 74274 [details] Patch
Steve Falkenburg
Comment 2 2010-11-18 12:09:32 PST
Created attachment 74276 [details] Patch
Adam Roben (:aroben)
Comment 3 2010-11-18 12:21:28 PST
Comment on attachment 74276 [details] Patch The bug title and ChangeLogs are a little confusing, since this patch doesn't get rid of Debug_Internal.
Build Bot
Comment 4 2010-11-18 13:29:21 PST
Attachment 74276 [details] did not build on win: Build output: http://queues.webkit.org/results/6140067
Daniel Bates
Comment 5 2010-11-19 11:06:31 PST
The patch <https://bugs.webkit.org/attachment.cgi?id=74276> appears to been landed in changeset 72327 <http://trac.webkit.org/changeset/72327>. Marking this bug Resolved Fixed. If this is not the case, then re-open this bug.
Daniel Bates
Comment 6 2010-11-19 11:09:04 PST
From the changeset 72327 <http://trac.webkit.org/changeset/72327> the change log entries in this patch were inserted into the middle of the change log files. Instead, these entries should have been inserted at the top of their respective change log file. Obviously, the commit message for this change is wrong; it is a concatenation of several unrelated change logs entries.
Note You need to log in before you can comment on or make changes to this bug.