Bug 49753 - Debug_Internal Windows configuration is unnecessary, should be removed
Summary: Debug_Internal Windows configuration is unnecessary, should be removed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Steve Falkenburg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-18 11:40 PST by Steve Falkenburg
Modified: 2010-11-19 11:09 PST (History)
3 users (show)

See Also:

Attachments
Patch (7.31 KB, patch)
2010-11-18 12:06 PST, Steve Falkenburg 		no flags Details | Formatted Diff | Diff
Patch (7.28 KB, patch)
2010-11-18 12:09 PST, Steve Falkenburg 		aroben: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Falkenburg 2010-11-18 11:40:17 PST 
Debug_Internal Windows configuration is unnecessary, should be removed
Comment 1 Steve Falkenburg 2010-11-18 12:06:23 PST 
Created attachment 74274 [details]
Patch
Comment 2 Steve Falkenburg 2010-11-18 12:09:32 PST 
Created attachment 74276 [details]
Patch
Comment 3 Adam Roben (:aroben) 2010-11-18 12:21:28 PST 
Comment on attachment 74276 [details]
Patch

The bug title and ChangeLogs are a little confusing, since this patch doesn't get rid of Debug_Internal.
Comment 4 Build Bot 2010-11-18 13:29:21 PST 
Attachment 74276 [details] did not build on win:
Build output: http://queues.webkit.org/results/6140067
Comment 5 Daniel Bates 2010-11-19 11:06:31 PST 
The patch <https://bugs.webkit.org/attachment.cgi?id=74276> appears to been landed in changeset 72327 <http://trac.webkit.org/changeset/72327>.

Marking this bug Resolved Fixed. If this is not the case, then re-open this bug.
Comment 6 Daniel Bates 2010-11-19 11:09:04 PST 
From the changeset 72327 <http://trac.webkit.org/changeset/72327> the change log entries in this patch were inserted into the middle of the change log files. Instead, these entries should have been inserted at the top of their respective change log file. Obviously, the commit message for this change is wrong; it is a concatenation of several unrelated change logs entries.