When loading: compositing/masks/simple-composited-mask.html the top image in the composited column is blank. This is with a recent nightly build: Version 5.0 (6533.16, r72146) It also occasionally happens for the masked-ancestor test, after successive reloads. I did spend a little bit of time trying to debug this and it appears that the mask layer's bounds are zero when that happens.
I can reproduce. I think this must have regressed at some point.
<rdar://problem/8683794>
The mask isn't getting painted for some reason.
The masked compositing layer is 0x0; it gets its size via box->maskClipRect() but that returns 0x0 before the image has loaded. So when the mask image loads, we need to rejigger some composting geometry.
Created attachment 76503 [details] Patch
Comment on attachment 76503 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=76503&action=review > WebCore/rendering/RenderLayerBacking.cpp:801 > - if (isDirectlyCompositedImage()) { > + if ((changeType == RenderLayer::ImageChanged) && isDirectlyCompositedImage()) { This method’s body can now be a switch statement.
Attachment 76503 [details] did not build on chromium: Build output: http://queues.webkit.org/results/6977103
Attachment 76503 [details] did not build on chromium: Build output: http://queues.webkit.org/results/6889119
Comment on attachment 76503 [details] Patch Seems this patch will need an update to avoid breaking Chromium.
(In reply to comment #9) > (From update of attachment 76503 [details]) > Seems this patch will need an update to avoid breaking Chromium. Definitely. I'll update and resubmit! Thanks.
I can take care of it.
http://trac.webkit.org/changeset/74066
http://trac.webkit.org/changeset/74066 might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: fast/css/focus-ring-detached.html fast/css/focus-ring-multiline.html