Bug 49708 - Stop recompiling functions to regenerate exception info.
Summary: Stop recompiling functions to regenerate exception info.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-17 19:30 PST by Gavin Barraclough
Modified: 2010-11-18 18:35 PST (History)
0 users

See Also:


Attachments
Preliminary patch (53.55 KB, patch)
2010-11-17 19:31 PST, Gavin Barraclough
no flags Details | Formatted Diff | Diff
the patch (56.16 KB, patch)
2010-11-18 18:20 PST, Gavin Barraclough
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2010-11-17 19:30:32 PST
Instead only hold info as necessary – keep divot info is the inspector is enabled, line number info is debugging or profiling, and handler info for functions with try/catch.
Comment 1 Gavin Barraclough 2010-11-17 19:31:02 PST
Created attachment 74196 [details]
Preliminary patch
Comment 2 Gavin Barraclough 2010-11-18 18:20:22 PST
Created attachment 74336 [details]
the patch
Comment 3 Oliver Hunt 2010-11-18 18:25:52 PST
Comment on attachment 74336 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=74336&action=review

> WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm:992
> +//    return shouldOpenWebInspector(pathOrURL) || strstr(pathOrURL, "inspector-enabled/");

Fix this!!!
Comment 4 Gavin Barraclough 2010-11-18 18:35:43 PST
fixed in r72360