The assertion I added to StyleSheet constructor was wrong.
Created attachment 74181 [details] proposed fix
Attachment 74181 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/xsl/import-non-document-node-expected.txt', u'LayoutTests/fast/xsl/import-non-document-node.xhtml', u'WebCore/ChangeLog', u'WebCore/css/CSSStyleSheet.cpp', u'WebCore/css/StyleSheet.cpp']" exit_code: 1 WebCore/css/CSSStyleSheet.cpp:51: Line contains only semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 74181 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=74181&action=review > WebCore/css/CSSStyleSheet.cpp:50 > +#if ENABLE(SVG) > + || parentNode->hasTagName(SVGNames::styleTag) > +#endif If you moved this expression up one line so it was next to the HTML style tag, then you could use a more-normal semicolon-on-end-of-line.
Created attachment 74214 [details] patch for landing
Comment on attachment 74214 [details] patch for landing Commit-queue ignored this, landing manually.
Committed <http://trac.webkit.org/changeset/72301>.
http://trac.webkit.org/changeset/72301 might have broken Qt Linux Release The following tests are not passing: fast/xsl/import-non-document-node.xhtml
Disabled the test for Qt in <http://trac.webkit.org/changeset/72308>, filed bug 49743.