Rebaseline server: add loupe for image diffs
Created attachment 74163 [details] Patch
Comment on attachment 74163 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=74163&action=review This sounds awesome. I'll have to try the rebaseline tool after this lands. r- for naming style, otherwise, this looks good. > WebKitTools/Scripts/webkitpy/tool/commands/data/rebaselineserver/loupe.js:37 > + this.node_ = $('loupe'); > + this.currentCornerX_ = -1; > + this.currentCornerY_ = -1; There's no real webkit style for JS objects. Ojan and I discussed briefly and he suggested just using _node and _currentCornerX for the following reasons: 1) JS outside of google seems to use prefix _ more than suffix _. 2) It's similar to PEP8 and JS seems more like python than C++. > WebKitTools/Scripts/webkitpy/tool/commands/data/rebaselineserver/loupe.js:55 > +Loupe.prototype.handleOutputClick_ = function(event) To go with the above recommendation, this would be _handleOutputClick.
Created attachment 74176 [details] Patch
Switched to leading underscore in new version of the patch.
Committed r72262: <http://trac.webkit.org/changeset/72262>