RESOLVED FIXED 49692
Rebaseline server: add loupe for image diffs 
https://bugs.webkit.org/show_bug.cgi?id=49692
Summary Rebaseline server: add loupe for image diffs
Mihai Parparita
Reported 2010-11-17 15:27:25 PST
Rebaseline server: add loupe for image diffs
Attachments
Patch (14.25 KB, patch)
2010-11-17 15:29 PST, Mihai Parparita 		no flags
DetailsFormatted DiffDiff
Patch (14.22 KB, patch)
2010-11-17 16:34 PST, Mihai Parparita 		tony: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mihai Parparita
Comment 1 2010-11-17 15:29:27 PST
Created attachment 74163 [details] Patch
Tony Chang
Comment 2 2010-11-17 16:26:09 PST
Comment on attachment 74163 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=74163&action=review This sounds awesome. I'll have to try the rebaseline tool after this lands. r- for naming style, otherwise, this looks good. > WebKitTools/Scripts/webkitpy/tool/commands/data/rebaselineserver/loupe.js:37 > + this.node_ = $('loupe'); > + this.currentCornerX_ = -1; > + this.currentCornerY_ = -1; There's no real webkit style for JS objects. Ojan and I discussed briefly and he suggested just using _node and _currentCornerX for the following reasons: 1) JS outside of google seems to use prefix _ more than suffix _. 2) It's similar to PEP8 and JS seems more like python than C++. > WebKitTools/Scripts/webkitpy/tool/commands/data/rebaselineserver/loupe.js:55 > +Loupe.prototype.handleOutputClick_ = function(event) To go with the above recommendation, this would be _handleOutputClick.
Mihai Parparita
Comment 3 2010-11-17 16:34:33 PST
Created attachment 74176 [details] Patch
Mihai Parparita
Comment 4 2010-11-17 16:34:57 PST
Switched to leading underscore in new version of the patch.
Mihai Parparita
Comment 5 2010-11-17 16:42:36 PST
Committed r72262: <http://trac.webkit.org/changeset/72262>
Note You need to log in before you can comment on or make changes to this bug.