WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
49690
DumpRenderTree on Windows should use a vsprops file for shared project settings
https://bugs.webkit.org/show_bug.cgi?id=49690
Summary
DumpRenderTree on Windows should use a vsprops file for shared project settings
Steve Falkenburg
Reported
2010-11-17 14:48:37 PST
DumpRenderTree on Windows should use a vsprops file for shared project settings
Attachments
Patch
(108.80 KB, patch)
2010-11-17 14:53 PST
,
Steve Falkenburg
aroben
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Steve Falkenburg
Comment 1
2010-11-17 14:53:40 PST
Created
attachment 74160
[details]
Patch
Adam Roben (:aroben)
Comment 2
2010-11-17 15:03:54 PST
Comment on
attachment 74160
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=74160&action=review
> WebKitTools/DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:41 > + AdditionalIncludeDirectories=""
Is this harmless? I've been removing it for my own changes.
> WebKitTools/DumpRenderTree/win/DumpRenderTreeCURL.vsprops:9 > + AdditionalDependencies="libcurl_imp.lib"
I think this whole file isn't needed. You can use WebKitLibraries/win/tools/vsprops/cURL.vsprops.
> WebKitTools/DumpRenderTree/win/DumpRenderTreeCairo.vsprops:13 > + AdditionalDependencies="cairo.lib libjpeg.lib libpng.lib"
I think this line isn't needed given that we're already using WinCairo.vsprops.
> WebKitTools/DumpRenderTree/win/ImageDiffCommon.vsprops:14 > + AdditionalDependencies="JavaScriptCore$(WebKitDLLConfigSuffix).lib CoreGraphics$(LibraryConfigSuffix).lib CoreFoundation$(LibraryConfigSuffix).lib"
Maybe we should put CG/CF in a ImageDiffApple.vsprops file instead? (Maybe we should add CG.vsprops and CF.vsprops in WebKitLibraries/win/tools/vsprops?)
Eric Seidel (no email)
Comment 3
2010-12-14 01:41:10 PST
Did this get landed?
Steve Falkenburg
Comment 4
2010-12-14 08:38:48 PST
Landed in
http://trac.webkit.org/changeset/72250
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug