Bug 49690 - DumpRenderTree on Windows should use a vsprops file for shared project settings
Summary: DumpRenderTree on Windows should use a vsprops file for shared project settings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Steve Falkenburg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-17 14:48 PST by Steve Falkenburg
Modified: 2010-12-14 08:38 PST (History)
1 user (show)

See Also:

Attachments
Patch (108.80 KB, patch)
2010-11-17 14:53 PST, Steve Falkenburg 		aroben: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Falkenburg 2010-11-17 14:48:37 PST 
DumpRenderTree on Windows should use a vsprops file for shared project settings
Comment 1 Steve Falkenburg 2010-11-17 14:53:40 PST 
Created attachment 74160 [details]
Patch
Comment 2 Adam Roben (:aroben) 2010-11-17 15:03:54 PST 
Comment on attachment 74160 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=74160&action=review

> WebKitTools/DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:41
> +				AdditionalIncludeDirectories=""

Is this harmless? I've been removing it for my own changes.

> WebKitTools/DumpRenderTree/win/DumpRenderTreeCURL.vsprops:9
> +		AdditionalDependencies="libcurl_imp.lib"

I think this whole file isn't needed. You can use WebKitLibraries/win/tools/vsprops/cURL.vsprops.

> WebKitTools/DumpRenderTree/win/DumpRenderTreeCairo.vsprops:13
> +		AdditionalDependencies="cairo.lib libjpeg.lib libpng.lib"

I think this line isn't needed given that we're already using WinCairo.vsprops.

> WebKitTools/DumpRenderTree/win/ImageDiffCommon.vsprops:14
> +		AdditionalDependencies="JavaScriptCore$(WebKitDLLConfigSuffix).lib CoreGraphics$(LibraryConfigSuffix).lib CoreFoundation$(LibraryConfigSuffix).lib"

Maybe we should put CG/CF in a ImageDiffApple.vsprops file instead? (Maybe we should add CG.vsprops and CF.vsprops in WebKitLibraries/win/tools/vsprops?)
Comment 3 Eric Seidel (no email) 2010-12-14 01:41:10 PST 
Did this get landed?
Comment 4 Steve Falkenburg 2010-12-14 08:38:48 PST 
Landed in http://trac.webkit.org/changeset/72250